From d8a5da51536b6116223af214fd75b31fd9909829 Mon Sep 17 00:00:00 2001 From: Spencer Ahrens Date: Thu, 11 Oct 2018 19:35:43 -0700 Subject: [PATCH] Fix some test stuff Summary: missing header and platform. attributedstring builds now, but still fails because of T34990592 Reviewed By: mdvacca Differential Revision: D10349210 fbshipit-source-id: dcd163df9ac9a4fcb36399cb9f93dbf1b33c062d --- ReactCommon/fabric/core/BUCK | 2 +- ReactCommon/fabric/debug/BUCK | 2 +- ReactCommon/fabric/debug/DebugStringConvertible.h | 1 + ReactCommon/fabric/events/BUCK | 2 +- ReactCommon/fabric/graphics/BUCK | 2 +- ReactCommon/fabric/imagemanager/BUCK | 2 +- ReactCommon/fabric/uimanager/BUCK | 2 +- 7 files changed, 7 insertions(+), 6 deletions(-) diff --git a/ReactCommon/fabric/core/BUCK b/ReactCommon/fabric/core/BUCK index cf2021d979e..6e22c107d54 100644 --- a/ReactCommon/fabric/core/BUCK +++ b/ReactCommon/fabric/core/BUCK @@ -68,7 +68,7 @@ fb_xplat_cxx_test( "-Wall", ], contacts = ["oncall+react_native@xmail.facebook.com"], - platforms = APPLE, + platforms = (ANDROID,APPLE), deps = [ "xplat//folly:molly", "xplat//third-party/gmock:gtest", diff --git a/ReactCommon/fabric/debug/BUCK b/ReactCommon/fabric/debug/BUCK index fed1fb6da04..e13f71ed026 100644 --- a/ReactCommon/fabric/debug/BUCK +++ b/ReactCommon/fabric/debug/BUCK @@ -71,7 +71,7 @@ fb_xplat_cxx_test( "-Wall", ], contacts = ["oncall+react_native@xmail.facebook.com"], - platforms = APPLE, + platforms = (ANDROID, APPLE), deps = [ "xplat//folly:molly", "xplat//third-party/gmock:gtest", diff --git a/ReactCommon/fabric/debug/DebugStringConvertible.h b/ReactCommon/fabric/debug/DebugStringConvertible.h index 65010551250..2c38093f177 100644 --- a/ReactCommon/fabric/debug/DebugStringConvertible.h +++ b/ReactCommon/fabric/debug/DebugStringConvertible.h @@ -7,6 +7,7 @@ #pragma once +#include #include #include #include diff --git a/ReactCommon/fabric/events/BUCK b/ReactCommon/fabric/events/BUCK index f2c21f24395..1804100d089 100644 --- a/ReactCommon/fabric/events/BUCK +++ b/ReactCommon/fabric/events/BUCK @@ -71,7 +71,7 @@ fb_xplat_cxx_test( "-Wall", ], contacts = ["oncall+react_native@xmail.facebook.com"], - platforms = APPLE, + platforms = (ANDROID,APPLE), deps = [ "xplat//folly:molly", "xplat//third-party/gmock:gtest", diff --git a/ReactCommon/fabric/graphics/BUCK b/ReactCommon/fabric/graphics/BUCK index 3d0e1d97635..c8ad013a528 100644 --- a/ReactCommon/fabric/graphics/BUCK +++ b/ReactCommon/fabric/graphics/BUCK @@ -104,7 +104,7 @@ fb_xplat_cxx_test( "-Wall", ], contacts = ["oncall+react_native@xmail.facebook.com"], - platforms = APPLE, + platforms = (ANDROID,APPLE), deps = [ "xplat//folly:molly", "xplat//third-party/gmock:gtest", diff --git a/ReactCommon/fabric/imagemanager/BUCK b/ReactCommon/fabric/imagemanager/BUCK index 68627713c62..c2cbd424261 100644 --- a/ReactCommon/fabric/imagemanager/BUCK +++ b/ReactCommon/fabric/imagemanager/BUCK @@ -114,7 +114,7 @@ fb_xplat_cxx_test( "-Wall", ], contacts = ["oncall+react_native@xmail.facebook.com"], - platforms = APPLE, + platforms = (ANDROID, APPLE), deps = [ "xplat//folly:molly", "xplat//third-party/gmock:gtest", diff --git a/ReactCommon/fabric/uimanager/BUCK b/ReactCommon/fabric/uimanager/BUCK index 8962e6eec08..83c98d133f4 100644 --- a/ReactCommon/fabric/uimanager/BUCK +++ b/ReactCommon/fabric/uimanager/BUCK @@ -75,7 +75,7 @@ fb_xplat_cxx_test( "-Wall", ], contacts = ["oncall+react_native@xmail.facebook.com"], - platforms = APPLE, + platforms = (ANDROID, APPLE), deps = [ "xplat//folly:molly", "xplat//third-party/gmock:gtest",