From d7d5de9f9630e7dcd0194830d7ccb32f167b619c Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 5 Nov 2024 11:35:12 -0800 Subject: [PATCH] Stable API - Make `NativeModulePerfLogger` internal (#47415) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47415 This class should not be accessed directly, therefore I'm making it internal. Technically breaking but I verified that there are no meaningful usages in OSS: https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+com.facebook.react.reactperflogger.NativeModulePerfLogger Changelog: [Android] [Breaking] - Stable API - Make NativeModulePerfLogger internal Reviewed By: mdvacca Differential Revision: D65479550 fbshipit-source-id: 545c33e2c526e396084af65fc19314f59c8a74f8 --- .../ReactAndroid/api/ReactAndroid.api | 16 -------------- .../reactperflogger/NativeModulePerfLogger.kt | 22 +++++++++---------- 2 files changed, 11 insertions(+), 27 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 1c62bbff571..d8bf1e485e2 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -3763,22 +3763,6 @@ public abstract interface class com/facebook/react/packagerconnection/Responder public abstract fun respond (Ljava/lang/Object;)V } -public abstract class com/facebook/react/reactperflogger/NativeModulePerfLogger { - protected fun ()V - protected abstract fun initHybrid ()Lcom/facebook/jni/HybridData; - protected final fun maybeLoadOtherSoLibraries ()V - public abstract fun moduleCreateCacheHit (Ljava/lang/String;I)V - public abstract fun moduleCreateConstructEnd (Ljava/lang/String;I)V - public abstract fun moduleCreateConstructStart (Ljava/lang/String;I)V - public abstract fun moduleCreateEnd (Ljava/lang/String;I)V - public abstract fun moduleCreateFail (Ljava/lang/String;I)V - public abstract fun moduleCreateSetUpEnd (Ljava/lang/String;I)V - public abstract fun moduleCreateSetUpStart (Ljava/lang/String;I)V - public abstract fun moduleCreateStart (Ljava/lang/String;I)V - public abstract fun moduleDataCreateEnd (Ljava/lang/String;I)V - public abstract fun moduleDataCreateStart (Ljava/lang/String;I)V -} - public abstract class com/facebook/react/runtime/BindingsInstaller { public fun (Lcom/facebook/jni/HybridData;)V } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/NativeModulePerfLogger.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/NativeModulePerfLogger.kt index 8411d3cf92d..d141736e1a2 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/NativeModulePerfLogger.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/reactperflogger/NativeModulePerfLogger.kt @@ -9,7 +9,7 @@ package com.facebook.react.reactperflogger import com.facebook.jni.HybridData -public abstract class NativeModulePerfLogger protected constructor() { +internal abstract class NativeModulePerfLogger protected constructor() { @Suppress("NoHungarianNotation") private val mHybridData: HybridData @@ -20,25 +20,25 @@ public abstract class NativeModulePerfLogger protected constructor() { protected abstract fun initHybrid(): HybridData - public abstract fun moduleDataCreateStart(moduleName: String, id: Int) + abstract fun moduleDataCreateStart(moduleName: String, id: Int) - public abstract fun moduleDataCreateEnd(moduleName: String, id: Int) + abstract fun moduleDataCreateEnd(moduleName: String, id: Int) - public abstract fun moduleCreateStart(moduleName: String, id: Int) + abstract fun moduleCreateStart(moduleName: String, id: Int) - public abstract fun moduleCreateCacheHit(moduleName: String, id: Int) + abstract fun moduleCreateCacheHit(moduleName: String, id: Int) - public abstract fun moduleCreateConstructStart(moduleName: String, id: Int) + abstract fun moduleCreateConstructStart(moduleName: String, id: Int) - public abstract fun moduleCreateConstructEnd(moduleName: String, id: Int) + abstract fun moduleCreateConstructEnd(moduleName: String, id: Int) - public abstract fun moduleCreateSetUpStart(moduleName: String, id: Int) + abstract fun moduleCreateSetUpStart(moduleName: String, id: Int) - public abstract fun moduleCreateSetUpEnd(moduleName: String, id: Int) + abstract fun moduleCreateSetUpEnd(moduleName: String, id: Int) - public abstract fun moduleCreateEnd(moduleName: String, id: Int) + abstract fun moduleCreateEnd(moduleName: String, id: Int) - public abstract fun moduleCreateFail(moduleName: String, id: Int) + abstract fun moduleCreateFail(moduleName: String, id: Int) /** Subclasses will override this method to load their own SO libraries. */ @Synchronized