mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Expose an API to enable Concurrent Root on Android (#33645)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/33645 With React 18, we now need to allow users on Fabric to opt-in for Concurrent Root. This commit adds a new method that can be called on the ReactActivityDelegate that can be used to set the `concurrentRoot` flag on the `initialProps` on the Render. Changelog: [Android] [Added] - Expose an API to enable Concurrent Root on Android Reviewed By: mdvacca Differential Revision: D35614879 fbshipit-source-id: 2de83e8115d3748c0346cdec6f31b2ab1f899478
This commit is contained in:
committed by
Facebook GitHub Bot
parent
a12959546a
commit
d7b64b8d4b
@@ -0,0 +1,62 @@
|
||||
/*
|
||||
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
||||
*
|
||||
* This source code is licensed under the MIT license found in the
|
||||
* LICENSE file in the root directory of this source tree.
|
||||
*/
|
||||
|
||||
package com.facebook.react
|
||||
|
||||
import android.os.Bundle
|
||||
import org.junit.Assert.*
|
||||
import org.junit.Test
|
||||
import org.junit.runner.RunWith
|
||||
import org.robolectric.RobolectricTestRunner
|
||||
|
||||
@RunWith(RobolectricTestRunner::class)
|
||||
class ReactActivityDelegateTest {
|
||||
|
||||
@Test
|
||||
fun delegateWithConcurrentRoot_populatesInitialPropsCorrectly() {
|
||||
val delegate =
|
||||
object : ReactActivityDelegate(null, "test-delegate") {
|
||||
override fun isConcurrentRootEnabled() = true
|
||||
public val inspectLaunchOptions: Bundle?
|
||||
get() = getLaunchOptions()
|
||||
}
|
||||
|
||||
assertNotNull(delegate.inspectLaunchOptions)
|
||||
assertTrue(delegate.inspectLaunchOptions!!.containsKey("concurrentRoot"))
|
||||
assertTrue(delegate.inspectLaunchOptions!!.getBoolean("concurrentRoot"))
|
||||
}
|
||||
|
||||
@Test
|
||||
fun delegateWithoutConcurrentRoot_hasNullInitialProperties() {
|
||||
val delegate =
|
||||
object : ReactActivityDelegate(null, "test-delegate") {
|
||||
override fun isConcurrentRootEnabled() = false
|
||||
public val inspectLaunchOptions: Bundle?
|
||||
get() = getLaunchOptions()
|
||||
}
|
||||
|
||||
assertNull(delegate.inspectLaunchOptions)
|
||||
}
|
||||
|
||||
@Test
|
||||
fun delegateWithConcurrentRoot_composesInitialPropertiesCorrectly() {
|
||||
val delegate =
|
||||
object : ReactActivityDelegate(null, "test-delegate") {
|
||||
override fun isConcurrentRootEnabled() = true
|
||||
override fun getLaunchOptions(): Bundle =
|
||||
Bundle().apply { putString("test-property", "test-value") }
|
||||
public val inspectLaunchOptions: Bundle?
|
||||
get() = getLaunchOptions()
|
||||
}
|
||||
|
||||
assertNotNull(delegate.inspectLaunchOptions)
|
||||
assertTrue(delegate.inspectLaunchOptions!!.containsKey("concurrentRoot"))
|
||||
assertTrue(delegate.inspectLaunchOptions!!.getBoolean("concurrentRoot"))
|
||||
assertTrue(delegate.inspectLaunchOptions!!.containsKey("test-property"))
|
||||
assertEquals("test-value", delegate.inspectLaunchOptions!!.getString("test-property"))
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user