From d79dc48abd2e65e4d203e488f99eb554c473a1fc Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 30 Oct 2024 13:32:04 -0700 Subject: [PATCH] Delete RCTConstants.RCTGetMemoryPressureUnloadLevel (#47297) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47297 In this diff I'm proposing to remove configuration for RCTConstants.RCTGetMemoryPressureUnloadLevel API in iOS changelog: [iOS][Breaking] Delete experimental API RCTConstants.RCTGetMemoryPressureUnloadLevel Reviewed By: rubennorte, philIip Differential Revision: D65181556 fbshipit-source-id: c435bec6ed03562b53f1924add7b69ab517b190b --- packages/react-native/React/Base/RCTConstants.h | 6 ------ packages/react-native/React/Base/RCTConstants.m | 16 ---------------- .../react-native/React/CxxBridge/RCTCxxBridge.mm | 3 ++- 3 files changed, 2 insertions(+), 23 deletions(-) diff --git a/packages/react-native/React/Base/RCTConstants.h b/packages/react-native/React/Base/RCTConstants.h index 51a3967d1af..72bbb0f7b5c 100644 --- a/packages/react-native/React/Base/RCTConstants.h +++ b/packages/react-native/React/Base/RCTConstants.h @@ -50,9 +50,3 @@ RCT_EXTERN NSString *const RCTDidInitializeModuleNotification; */ RCT_EXTERN BOOL RCTGetDispatchW3CPointerEvents(void); RCT_EXTERN void RCTSetDispatchW3CPointerEvents(BOOL value); - -/* - * Memory Pressure Unloading Level - */ -RCT_EXTERN int RCTGetMemoryPressureUnloadLevel(void); -RCT_EXTERN void RCTSetMemoryPressureUnloadLevel(int value); diff --git a/packages/react-native/React/Base/RCTConstants.m b/packages/react-native/React/Base/RCTConstants.m index f348841d6ad..eb90640789f 100644 --- a/packages/react-native/React/Base/RCTConstants.m +++ b/packages/react-native/React/Base/RCTConstants.m @@ -38,19 +38,3 @@ void RCTSetDispatchW3CPointerEvents(BOOL value) { RCTDispatchW3CPointerEvents = value; } - -/* - * Memory Pressure Unloading Level for experimentation only. - * Default is 15, which is TRIM_MEMORY_RUNNING_CRITICAL. - */ -static int RCTMemoryPressureUnloadLevel = 15; - -int RCTGetMemoryPressureUnloadLevel(void) -{ - return RCTMemoryPressureUnloadLevel; -} - -void RCTSetMemoryPressureUnloadLevel(int value) -{ - RCTMemoryPressureUnloadLevel = value; -} diff --git a/packages/react-native/React/CxxBridge/RCTCxxBridge.mm b/packages/react-native/React/CxxBridge/RCTCxxBridge.mm index 4bf83305b02..dc3c753de65 100644 --- a/packages/react-native/React/CxxBridge/RCTCxxBridge.mm +++ b/packages/react-native/React/CxxBridge/RCTCxxBridge.mm @@ -371,7 +371,8 @@ struct RCTInstanceCallback : public InstanceCallback { // in case if some other tread resets it. auto reactInstance = _reactInstance; if (reactInstance) { - int unloadLevel = RCTGetMemoryPressureUnloadLevel(); + // Memory Pressure Unloading Level 15 represents TRIM_MEMORY_RUNNING_CRITICAL. + int unloadLevel = 15; reactInstance->handleMemoryPressure(unloadLevel); } }