Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix ReadableArray annotations (#30122)

Browse Source 
Summary:
Fix ReadableArray annotations, because these methods throw ArrayIndexOutOfBoundsException instead of null if index is not found.

## Changelog

[Android] [Changed] - fix ReadableArray null annotations. Possibly breaking change for Kotlin apps.

Pull Request resolved: https://github.com/facebook/react-native/pull/30122

Test Plan: RNTester app builds and runs as expected, and show correct type in when used with Kotlin code.

Reviewed By: JoshuaGross

Differential Revision: D24164326

Pulled By: fkgozali

fbshipit-source-id: 0c3f8fa9accbd32cc71c50befe9330e5201643f6
This commit is contained in:
Dulmandakh
2020-10-07 11:26:08 -07:00
committed by Facebook GitHub Bot
parent 4d4992c790
commit d76556543f
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableNativeArray.java
+3 -3
View File
@@ -98,17 +98,17 @@ public class ReadableNativeArray extends NativeArray implements ReadableArray {
}
@Override
public @Nullable String getString(int index) {
public @NonNull String getString(int index) {
return (String) getLocalArray()[index];
}
@Override
public @Nullable ReadableNativeArray getArray(int index) {
public @NonNull ReadableNativeArray getArray(int index) {
return (ReadableNativeArray) getLocalArray()[index];
}
@Override
public @Nullable ReadableNativeMap getMap(int index) {
public @NonNull ReadableNativeMap getMap(int index) {
return (ReadableNativeMap) getLocalArray()[index];
}