Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix ReadableArray annotations (#30122)

Browse Source 
Summary:
Fix ReadableArray annotations, because these methods throw ArrayIndexOutOfBoundsException instead of null if index is not found.

## Changelog

[Android] [Changed] - fix ReadableArray null annotations. Possibly breaking change for Kotlin apps.

Pull Request resolved: https://github.com/facebook/react-native/pull/30122

Test Plan: RNTester app builds and runs as expected, and show correct type in when used with Kotlin code.

Reviewed By: JoshuaGross

Differential Revision: D24164326

Pulled By: fkgozali

fbshipit-source-id: 0c3f8fa9accbd32cc71c50befe9330e5201643f6
This commit is contained in:
Dulmandakh
2020-10-07 11:28:30 -07:00
committed by Facebook GitHub Bot
parent 4d4992c790
commit d76556543f
2 changed files with 6 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/bridge/ReadableArray.java
+3 -4
View File
@@ -8,7 +8,6 @@
package com.facebook.react.bridge;
import androidx.annotation.NonNull;
import androidx.annotation.Nullable;
import java.util.ArrayList;
/**
@@ -27,13 +26,13 @@ public interface ReadableArray {
int getInt(int index);
@Nullable
@NonNull
String getString(int index);
@Nullable
@NonNull
ReadableArray getArray(int index);
@Nullable
@NonNull
ReadableMap getMap(int index);
@NonNull