From d6d31a4b6676f441b7fa06a0cd74b20e409c3b2b Mon Sep 17 00:00:00 2001 From: empyrical Date: Wed, 28 Nov 2018 16:40:16 -0800 Subject: [PATCH] JSBigString: Explicitly include unistd.h (#22330) Summary: `JSBigString` is using functions from `unistd.h`, like `getpagesize`, `dup`, `open`, etc. but was not directly including it. It was being included from inside the glog `logging.h` header, which in turn was getting included by the Folly headers `JSBigString` was using. This was discovered while building CxxReact with a custom shimmed Glog. Pull Request resolved: https://github.com/facebook/react-native/pull/22330 Differential Revision: D13115346 Pulled By: shergin fbshipit-source-id: 9fe4e3b28f74c0ca351ac6308484e375eace4db4 --- ReactCommon/cxxreact/JSBigString.h | 1 + 1 file changed, 1 insertion(+) diff --git a/ReactCommon/cxxreact/JSBigString.h b/ReactCommon/cxxreact/JSBigString.h index 8711107a0fe..e3cc5af292e 100644 --- a/ReactCommon/cxxreact/JSBigString.h +++ b/ReactCommon/cxxreact/JSBigString.h @@ -7,6 +7,7 @@ #include #include +#include #include