From d63648bac6f1e10cdb2203515111cd3492562f18 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Tue, 20 Oct 2026 07:39:48 -0700 Subject: [PATCH] Remove deprecated rncore.h header (#59228) Summary: Pull Request resolved: https://github.com/react/react-native/pull/59228 `rncore.h` is a deprecated forwarding shim left from renaming the core codegen module to `FBReactNativeSpec`. It only includes `FBReactNativeSpec.h`, aliases `rncore_ModuleProvider` to `FBReactNativeSpec_ModuleProvider`, and emits a `#warning` asking callers to migrate. Nothing in the repository includes it any more, so delete the header, drop it from the Android JNI target's exported headers, and point the last stale mention in the default app setup comment at the supported symbol. Changelog: [Android][Breaking] - Remove deprecated `rncore.h`; include `FBReactNativeSpec.h` and call `FBReactNativeSpec_ModuleProvider` instead Differential Revision: D126393806 fbshipit-source-id: f19f54eb769b1f86f5e7bfedfd8f34881fe103c0 --- .../cmake-utils/default-app-setup/OnLoad.cpp | 2 +- .../main/jni/react/newarchdefaults/rncore.h | 20 ------------------- .../api-snapshots/ReactAndroidDebugCxx.api | 1 - .../ReactAndroidFrameworksCxx.api | 1 - .../api-snapshots/ReactAndroidNewarchCxx.api | 1 - .../api-snapshots/ReactAndroidReleaseCxx.api | 1 - 6 files changed, 1 insertion(+), 25 deletions(-) delete mode 100644 packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/rncore.h diff --git a/packages/react-native/ReactAndroid/cmake-utils/default-app-setup/OnLoad.cpp b/packages/react-native/ReactAndroid/cmake-utils/default-app-setup/OnLoad.cpp index f79eb1a4551..299c011c39d 100644 --- a/packages/react-native/ReactAndroid/cmake-utils/default-app-setup/OnLoad.cpp +++ b/packages/react-native/ReactAndroid/cmake-utils/default-app-setup/OnLoad.cpp @@ -88,7 +88,7 @@ std::shared_ptr javaModuleProvider( // if (module != nullptr) { // return module; // } - // return rncore_ModuleProvider(name, params); + // return FBReactNativeSpec_ModuleProvider(name, params); // We link app local modules if available #ifdef REACT_NATIVE_APP_MODULE_PROVIDER diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/rncore.h b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/rncore.h deleted file mode 100644 index 8bc0f5f0ac4..00000000000 --- a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/rncore.h +++ /dev/null @@ -1,20 +0,0 @@ -/* - * Copyright (c) Meta Platforms, Inc. and affiliates. - * - * This source code is licensed under the MIT license found in the - * LICENSE file in the root directory of this source tree. - */ - -#include - -#warning \ - "[DEPRECATION] `rncore.h` is deprecated and will be removed in the future. \ - If this warning appears due to a library, please open an issue in that library, and ask for an update. \ - Please, replace the `#include ` statements with `#include ` \ - and update calls of `rncore_ModuleProvider` with `FBReactNativeSpec_ModuleProvider`." - -namespace facebook::react { - -constexpr auto rncore_ModuleProvider = FBReactNativeSpec_ModuleProvider; - -} diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 815efad8a90..7579a261eb0 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -375,7 +375,6 @@ struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast { const char facebook::react::ViewComponentName[]; const facebook::react::EventTag facebook::react::EMPTY_EVENT_TAG; -constexpr auto facebook::react::rncore_ModuleProvider; constexpr facebook::react::ReactNativeVersionType facebook::react::ReactNativeVersion; constexpr facebook::react::Tag facebook::react::kNoTag; constexpr uint32_t facebook::react::INITIAL_BUCKETS_SIZE; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api index c33b628014f..69efb6e2de0 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidFrameworksCxx.api @@ -386,7 +386,6 @@ const char facebook::react::TextComponentName[]; const char facebook::react::ViewComponentName[]; const facebook::react::EventTag facebook::react::EMPTY_EVENT_TAG; constexpr auto facebook::react::kSimpleThreadSafeCacheSizeCap; -constexpr auto facebook::react::rncore_ModuleProvider; constexpr char facebook::react::LayoutConformanceShadowNodeComponentName[]; constexpr char* const facebook::react::TextLayoutManagerKey; constexpr facebook::react::ReactNativeVersionType facebook::react::ReactNativeVersion; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index 349e6e4de87..3b07cc3df7c 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -375,7 +375,6 @@ struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast { const char facebook::react::ViewComponentName[]; const facebook::react::EventTag facebook::react::EMPTY_EVENT_TAG; -constexpr auto facebook::react::rncore_ModuleProvider; constexpr facebook::react::ReactNativeVersionType facebook::react::ReactNativeVersion; constexpr facebook::react::Tag facebook::react::kNoTag; constexpr uint32_t facebook::react::INITIAL_BUCKETS_SIZE; diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index 349e6e4de87..3b07cc3df7c 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -375,7 +375,6 @@ struct facebook::hermes::ISetEventLoopControl : public facebook::jsi::ICast { const char facebook::react::ViewComponentName[]; const facebook::react::EventTag facebook::react::EMPTY_EVENT_TAG; -constexpr auto facebook::react::rncore_ModuleProvider; constexpr facebook::react::ReactNativeVersionType facebook::react::ReactNativeVersion; constexpr facebook::react::Tag facebook::react::kNoTag; constexpr uint32_t facebook::react::INITIAL_BUCKETS_SIZE;