Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add override for debug warning highlights for non-performant views and commands.

Browse Source 
Summary: Adds a flag that can be set in FlatViewGroup to see known performance issues in Nodes objects.  This is mostly useful in internal development of Nodes, and will be a dead code path when not set.

Reviewed By: ahmedre

Differential Revision: D3732675
This commit is contained in:
Seth Kirby
2016-08-17 18:13:27 -07:00
committed by Ahmed El-Helw
parent 4a12efad02
commit d601cc084b
5 changed files with 104 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/flat/AbstractDrawCommand.java
+51 -1
View File
@@ -11,6 +11,8 @@ package com.facebook.react.flat;
import android.graphics.Canvas;
import android.graphics.Color;
import android.graphics.Paint;
import android.graphics.Typeface;
/**
* Base class for all DrawCommands. Becomes immutable once it has its bounds set. Until then, a
@@ -33,6 +35,11 @@ import android.graphics.Color;
private float mClipRight;
private float mClipBottom;
// Used to draw highlights in debug draw.
private static Paint sDebugHighlightRed;
private static Paint sDebugHighlightYellow;
private static Paint sDebugHighlightOverlayText;
public final boolean clipBoundsMatch(
float clipLeft,
float clipTop,
@@ -104,8 +111,48 @@ import android.graphics.Color;
return getClass().getSimpleName().substring(4);
}
private void initDebugHighlightResources(FlatViewGroup parent) {
if (sDebugHighlightRed == null) {
sDebugHighlightRed = new Paint();
sDebugHighlightRed.setARGB(75, 255, 0, 0);
}
if (sDebugHighlightYellow == null) {
sDebugHighlightYellow = new Paint();
sDebugHighlightYellow.setARGB(100, 255, 204, 0);
}
if (sDebugHighlightOverlayText == null) {
sDebugHighlightOverlayText = new Paint();
sDebugHighlightOverlayText.setAntiAlias(true);
sDebugHighlightOverlayText.setARGB(200, 50, 50, 50);
sDebugHighlightOverlayText.setTextAlign(Paint.Align.RIGHT);
sDebugHighlightOverlayText.setTypeface(Typeface.MONOSPACE);
sDebugHighlightOverlayText.setTextSize(parent.dipsToPixels(9));
}
}
private void debugDrawHighlightRect(Canvas canvas, Paint paint, String text) {
canvas.drawRect(getLeft(), getTop(), getRight(), getBottom(), paint);
canvas.drawText(text, getRight() - 5, getBottom() - 5, sDebugHighlightOverlayText);
}
protected void debugDrawWarningHighlight(Canvas canvas, String text) {
debugDrawHighlightRect(canvas, sDebugHighlightRed, text);
}
protected void debugDrawCautionHighlight(Canvas canvas, String text) {
debugDrawHighlightRect(canvas, sDebugHighlightYellow, text);
}
@Override
public void debugDraw(FlatViewGroup parent, Canvas canvas) {
public final void debugDraw(FlatViewGroup parent, Canvas canvas) {
onDebugDraw(parent, canvas);
if (FlatViewGroup.DEBUG_HIGHLIGHT_PERFORMANCE_ISSUES) {
initDebugHighlightResources(parent);
onDebugDrawHighlight(canvas);
}
}
protected void onDebugDraw(FlatViewGroup parent, Canvas canvas) {
parent.debugDrawNamedRect(
canvas,
getDebugBorderColor(),
@@ -116,6 +163,9 @@ import android.graphics.Color;
mBottom);
}
protected void onDebugDrawHighlight(Canvas canvas) {
}
protected void onPreDraw(FlatViewGroup parent, Canvas canvas) {
}