From d53dbb0dfb99bdee5cd7eeaaa6f4ae51dcca00c5 Mon Sep 17 00:00:00 2001 From: Dulmandakh Date: Tue, 5 Feb 2019 10:26:32 -0800 Subject: [PATCH] =?UTF-8?q?SuppressLint("MissingPermission")=20in=20Locati?= =?UTF-8?q?on,=20NetInfo,=20Vibration=20mod=E2=80=A6=20(#23294)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Location, NetInfo and Vibration modules require its own permissions to work properly, and Android Studio and lint shows warning in the modules because permissions are not found in AndroidManifest.xml of ReactAndroid, due to that not all apps require these functionalities/permissions. Therefore, developers have to add required permissions if they want to use before mentioned functionalities. This PR suppresses missing permission warnings. [Android] [Changed] - Suppress missing permission warnings Pull Request resolved: https://github.com/facebook/react-native/pull/23294 Differential Revision: D13959120 Pulled By: cpojer fbshipit-source-id: 10526f1218989b805528a5415e03371d5865be63 --- .../com/facebook/react/modules/location/LocationModule.java | 2 ++ .../java/com/facebook/react/modules/netinfo/NetInfoModule.java | 2 ++ .../com/facebook/react/modules/vibration/VibrationModule.java | 2 ++ 3 files changed, 6 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/location/LocationModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/location/LocationModule.java index 4f0b0ce6ccd..22d6b9f405e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/location/LocationModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/location/LocationModule.java @@ -7,6 +7,7 @@ package com.facebook.react.modules.location; +import android.annotation.SuppressLint; import android.content.Context; import android.location.Location; import android.location.LocationListener; @@ -32,6 +33,7 @@ import javax.annotation.Nullable; /** * Native module that exposes Geolocation to JS. */ +@SuppressLint("MissingPermission") @ReactModule(name = LocationModule.NAME) public class LocationModule extends ReactContextBaseJavaModule { diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/netinfo/NetInfoModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/netinfo/NetInfoModule.java index 156a3ca0263..ac67030f7d7 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/netinfo/NetInfoModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/netinfo/NetInfoModule.java @@ -7,6 +7,7 @@ package com.facebook.react.modules.netinfo; +import android.annotation.SuppressLint; import android.content.BroadcastReceiver; import android.content.Context; import android.content.Intent; @@ -30,6 +31,7 @@ import static com.facebook.react.modules.core.DeviceEventManagerModule.RCTDevice /** * Module that monitors and provides information about the connectivity state of the device. */ +@SuppressLint("MissingPermission") @ReactModule(name = NetInfoModule.NAME) public class NetInfoModule extends ReactContextBaseJavaModule implements LifecycleEventListener { diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/VibrationModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/VibrationModule.java index a224b556af4..153f800f775 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/VibrationModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/vibration/VibrationModule.java @@ -7,6 +7,7 @@ package com.facebook.react.modules.vibration; +import android.annotation.SuppressLint; import android.content.Context; import android.os.Vibrator; @@ -16,6 +17,7 @@ import com.facebook.react.bridge.ReactMethod; import com.facebook.react.bridge.ReadableArray; import com.facebook.react.module.annotations.ReactModule; +@SuppressLint("MissingPermission") @ReactModule(name = VibrationModule.NAME) public class VibrationModule extends ReactContextBaseJavaModule {