From d4adf50e1e3fbc913fc80c49e32caff11aa32f8f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?S=C3=A9bastien=20Lorber?= Date: Fri, 15 Feb 2019 08:14:20 -0800 Subject: [PATCH] Android - decouple TextInput cursorColor from selectionColor (#20276) Summary: Basically I want my cursor to be the same color of the text. Which means obviously that selecting the text will make it invisibible (ie, red text on red selection rectangle) Today, setting a selection color does set a cursor color, which may be a good default in some cases, but we don't always couple these 2 colors together. See original commit of janicduplessis https://github.com/facebook/react-native/commit/ae57b25134c4db8be8539a0f0e6e52d46c850339 I'd like to be able to set different colors for selection and cursor. Pull Request resolved: https://github.com/facebook/react-native/pull/20276 Differential Revision: D14102952 Pulled By: cpojer fbshipit-source-id: 652ff782044277a0c8a821dd628f0373659a7850 --- .../facebook/react/views/textinput/ReactTextInputManager.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java index 363511025c1..3ad69adba04 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputManager.java @@ -354,7 +354,8 @@ public class ReactTextInputManager extends BaseViewManager