mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
Add codegen support for DimensionValue for components (#35953)
Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/35953 DimensionValue is a reserved prop type that can be a number or string (such as '50%'). On Java, it will get converted to a YogaValue (converter added to this diff); on C++ it will get converted to a YGValue (converter already exists as it's used in Fabric). Changelog: [Internal][Added] - Add codegen support for DimensionValue for components Reviewed By: cipolleschi Differential Revision: D42650799 fbshipit-source-id: 1d2bc30bbd93837dedbbb4c74f814963c8140957
This commit is contained in:
committed by
Facebook GitHub Bot
parent
97e707d897
commit
d3cc48d9a6
Vendored
+12
@@ -23,6 +23,7 @@ function toJavaType(
|
||||
const importReadableMap = () =>
|
||||
addImport('com.facebook.react.bridge.ReadableMap');
|
||||
const importArrayList = () => addImport('java.util.ArrayList');
|
||||
const importYogaValue = () => addImport('com.facebook.yoga.YogaValue');
|
||||
switch (typeAnnotation.type) {
|
||||
/**
|
||||
* Primitives
|
||||
@@ -98,6 +99,12 @@ function toJavaType(
|
||||
importNullable();
|
||||
importReadableMap();
|
||||
return '@Nullable ReadableMap';
|
||||
|
||||
case 'DimensionPrimitive':
|
||||
importNullable();
|
||||
importYogaValue();
|
||||
return '@Nullable YogaValue';
|
||||
|
||||
default:
|
||||
(typeAnnotation.name: empty);
|
||||
throw new Error(
|
||||
@@ -182,6 +189,11 @@ function toJavaType(
|
||||
case 'EdgeInsetsPrimitive':
|
||||
importReadableMap();
|
||||
return 'ReadableMap';
|
||||
|
||||
case 'DimensionPrimitive':
|
||||
importYogaValue();
|
||||
return 'YogaValue';
|
||||
|
||||
default:
|
||||
(elementType.name: empty);
|
||||
throw new Error(
|
||||
|
||||
Reference in New Issue
Block a user