From d393fa940cb63c676189c2eb99338b01c7c2aabb Mon Sep 17 00:00:00 2001 From: Dustin Shahidehpour Date: Wed, 29 Jan 2020 12:59:51 -0800 Subject: [PATCH] delete rn_plugin_apple_library Summary: We can now use `rn_apple_library` to the same effect. Changelog: [Internal] Reviewed By: adamjernst Differential Revision: D19610730 fbshipit-source-id: 98353b062229c192447d1f49e6fe9bdcf12c6a96 --- tools/build_defs/oss/rn_defs.bzl | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/tools/build_defs/oss/rn_defs.bzl b/tools/build_defs/oss/rn_defs.bzl index d78a6c93003..3cb54bca833 100644 --- a/tools/build_defs/oss/rn_defs.bzl +++ b/tools/build_defs/oss/rn_defs.bzl @@ -169,17 +169,11 @@ def rn_apple_library(*args, **kwargs): kwargs.setdefault("link_whole", True) kwargs.setdefault("enable_exceptions", True) kwargs.setdefault("target_sdk_version", "10.0") + _ = kwargs.pop("plugins_only", False) native.apple_library(*args, **kwargs) -def rn_plugin_apple_library(**kwargs): - kwargs.setdefault("link_whole", True) - kwargs.setdefault("target_sdk_version", "10.0") - - # This just an alias to apple_library for now. - native.apple_library(**kwargs) - def rn_java_library(*args, **kwargs): - is_androidx = kwargs.pop("is_androidx", False) + _ = kwargs.pop("is_androidx", False) native.java_library(*args, **kwargs) def rn_java_annotation_processor(*args, **kwargs):