From d28d4c5ff8be54f45f8f327f00aa7581f997d795 Mon Sep 17 00:00:00 2001 From: Arushi Kesarwani Date: Wed, 23 Apr 2025 16:56:45 -0700 Subject: [PATCH] Rename Codegen Component Descriptors Entrypoint for FAC and hook it up in DefaultComponentsRegistry (#50881) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/50881 Rename Codegen Component Descriptors Entrypoint for FAC and hook it up in DefaultComponentsRegistry Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D73535745 fbshipit-source-id: dad68e7e6c8d7ba2ed86bbd1c06131101e00689e --- .../newarchdefaults/DefaultComponentsRegistry.cpp | 10 ++++++++++ .../react/newarchdefaults/DefaultComponentsRegistry.h | 4 ++++ 2 files changed, 14 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.cpp index 543b387b217..67716a95394 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.cpp @@ -18,6 +18,10 @@ namespace facebook::react { std::function)> DefaultComponentsRegistry::registerComponentDescriptorsFromEntryPoint{}; +std::function)> + DefaultComponentsRegistry:: + registerCodegenComponentDescriptorsFromEntryPoint{}; + void DefaultComponentsRegistry::setRegistryRunction( jni::alias_ref, ComponentFactory* delegate) { @@ -31,6 +35,12 @@ void DefaultComponentsRegistry::setRegistryRunction( .flavor = nullptr}; auto providerRegistry = CoreComponentsRegistry::sharedProviderRegistry(); + if (registerCodegenComponentDescriptorsFromEntryPoint) { + registerCodegenComponentDescriptorsFromEntryPoint(providerRegistry); + } else { + LOG(WARNING) + << "Codegen component descriptors were not configured from JNI_OnLoad"; + } if (registerComponentDescriptorsFromEntryPoint) { registerComponentDescriptorsFromEntryPoint(providerRegistry); } else { diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h index cf95b8709cf..9a27c7ba51a 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h +++ b/packages/react-native/ReactAndroid/src/main/jni/react/newarchdefaults/DefaultComponentsRegistry.h @@ -27,6 +27,10 @@ class DefaultComponentsRegistry std::shared_ptr)> registerComponentDescriptorsFromEntryPoint; + static std::function)> + registerCodegenComponentDescriptorsFromEntryPoint; + private: static void setRegistryRunction( jni::alias_ref,