From d25249442d63afe78a77d842192ac658a795fbce Mon Sep 17 00:00:00 2001 From: bufgix Date: Wed, 24 Jul 2024 00:14:28 -0700 Subject: [PATCH] =?UTF-8?q?chore:=20=E2=98=82=EF=B8=8F=20Migrate=20BlobMod?= =?UTF-8?q?uleTest.kt=20to=20AssertJ=20(#45610)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Summary: Issue: https://github.com/facebook/react-native/issues/45596 ## Changelog: [INTERNAL] [CHANGED] - Migrated to AssertJ within file `BlobModuleTest.kt` Pull Request resolved: https://github.com/facebook/react-native/pull/45610 Test Plan: `Run ./gradlew -p packages/gradle-plugin test` Reviewed By: mdvacca Differential Revision: D60138457 Pulled By: cortinico fbshipit-source-id: 8dcbede98130c24da2d81525d6596a8e4b4aa402 --- .../react/modules/blob/BlobModuleTest.kt | 22 +++++++++---------- 1 file changed, 10 insertions(+), 12 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/blob/BlobModuleTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/blob/BlobModuleTest.kt index 5b76831cc62..b137fcd9e08 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/blob/BlobModuleTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/modules/blob/BlobModuleTest.kt @@ -16,10 +16,8 @@ import com.facebook.react.bridge.WritableMap import java.nio.ByteBuffer import java.util.UUID import kotlin.random.Random +import org.assertj.core.api.Assertions.assertThat import org.junit.After -import org.junit.Assert.assertArrayEquals -import org.junit.Assert.assertNotNull -import org.junit.Assert.assertNull import org.junit.Before import org.junit.Test import org.junit.runner.RunWith @@ -56,9 +54,9 @@ class BlobModuleTest { @Test fun testResolve() { - assertArrayEquals(bytes, blobModule.resolve(blobId, 0, bytes.size)) + assertThat(blobModule.resolve(blobId, 0, bytes.size)).isEqualTo(bytes) val expectedRange = bytes.copyOfRange(30, bytes.size) - assertArrayEquals(expectedRange, blobModule.resolve(blobId, 30, bytes.size - 30)) + assertThat(blobModule.resolve(blobId, 30, bytes.size - 30)).isEqualTo(expectedRange) } @Test @@ -70,7 +68,7 @@ class BlobModuleTest { .appendQueryParameter("size", bytes.size.toString()) .build() - assertArrayEquals(bytes, blobModule.resolve(uri)) + assertThat(blobModule.resolve(uri)).isEqualTo(bytes) } @Test @@ -82,16 +80,16 @@ class BlobModuleTest { putInt("size", bytes.size) } - assertArrayEquals(bytes, blobModule.resolve(blob)) + assertThat(blobModule.resolve(blob)).isEqualTo(bytes) } @Test fun testRemove() { - assertNotNull(blobModule.resolve(blobId, 0, bytes.size)) + assertThat(blobModule.resolve(blobId, 0, bytes.size)).isNotNull() blobModule.remove(blobId) - assertNull(blobModule.resolve(blobId, 0, bytes.size)) + assertThat(blobModule.resolve(blobId, 0, bytes.size)).isNull() } @Test @@ -136,15 +134,15 @@ class BlobModuleTest { put(stringBytes) } - assertArrayEquals(result, buffer.array()) + assertThat(result).isEqualTo(buffer.array()) } @Test fun testRelease() { - assertNotNull(blobModule.resolve(blobId, 0, bytes.size)) + assertThat(blobModule.resolve(blobId, 0, bytes.size)).isNotNull() blobModule.release(blobId) - assertNull(blobModule.resolve(blobId, 0, bytes.size)) + assertThat(blobModule.resolve(blobId, 0, bytes.size)).isNull() } }