From d11954e800c255bd0765fa0da66b9bca8207b124 Mon Sep 17 00:00:00 2001 From: Edmond Chui Date: Thu, 17 Oct 2024 12:47:05 -0700 Subject: [PATCH] add appId to Telemetry (#47099) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47099 Changelog: [Internal] As discussed in D64547367, recent changes caused `description` to stop reporting `appId`. This impacted Telemetry's "top apps" dashboards. {F1936011487} Reviewed By: hoxyq Differential Revision: D64548348 fbshipit-source-id: 46af650a89e2bef7be000482e7b774f56f84cac3 --- packages/dev-middleware/src/middleware/openDebuggerMiddleware.js | 1 + packages/dev-middleware/src/types/EventReporter.js | 1 + 2 files changed, 2 insertions(+) diff --git a/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js b/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js index 490eb5d91f8..e10a3a9f5e2 100644 --- a/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js +++ b/packages/dev-middleware/src/middleware/openDebuggerMiddleware.js @@ -156,6 +156,7 @@ export default function openDebuggerMiddleware({ appId: appId ?? null, deviceId: device ?? null, resolvedTargetDescription: target.description, + resolvedTargetAppId: target.appId, prefersFuseboxFrontend: useFuseboxEntryPoint ?? false, }); return; diff --git a/packages/dev-middleware/src/types/EventReporter.js b/packages/dev-middleware/src/types/EventReporter.js index f578f745cf3..8c4bc2b52ae 100644 --- a/packages/dev-middleware/src/types/EventReporter.js +++ b/packages/dev-middleware/src/types/EventReporter.js @@ -41,6 +41,7 @@ export type ReportableEvent = appId: string | null, deviceId: string | null, resolvedTargetDescription: string, + resolvedTargetAppId: string, prefersFuseboxFrontend: boolean, }> | ErrorResult