From d0d97139a363b1c0117cdde97ff257ff506c584e Mon Sep 17 00:00:00 2001 From: David Vacca Date: Mon, 5 Feb 2024 18:05:24 -0800 Subject: [PATCH] Mark classes of packages turbmodules as @Nullsafe (#42853) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/42853 All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: cortinico Differential Revision: D53393135 fbshipit-source-id: 74a7f710eb7bf5a2e2b39e07ee4b026a425f521c --- .../facebook/react/turbomodule/core/CallInvokerHolderImpl.java | 2 ++ .../turbomodule/core/NativeMethodCallInvokerHolderImpl.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/CallInvokerHolderImpl.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/CallInvokerHolderImpl.java index 99e5e80c399..455eeb84077 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/CallInvokerHolderImpl.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/CallInvokerHolderImpl.java @@ -7,6 +7,7 @@ package com.facebook.react.turbomodule.core; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.jni.HybridData; import com.facebook.proguard.annotations.DoNotStrip; import com.facebook.react.common.annotations.FrameworkAPI; @@ -18,6 +19,7 @@ import com.facebook.react.turbomodule.core.interfaces.CallInvokerHolder; * TurboModuleManager. Therefore, we need to wrap JSCallInvoker within a hybrid class so that we may * pass it from CatalystInstance, through Java, to TurboModuleManager::initHybrid. */ +@Nullsafe(Nullsafe.Mode.LOCAL) @FrameworkAPI public class CallInvokerHolderImpl implements CallInvokerHolder { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/NativeMethodCallInvokerHolderImpl.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/NativeMethodCallInvokerHolderImpl.java index 96cc9761832..c68b5a69aab 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/NativeMethodCallInvokerHolderImpl.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/NativeMethodCallInvokerHolderImpl.java @@ -7,6 +7,7 @@ package com.facebook.react.turbomodule.core; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.jni.HybridData; import com.facebook.proguard.annotations.DoNotStrip; import com.facebook.react.common.annotations.FrameworkAPI; @@ -19,6 +20,7 @@ import com.facebook.react.turbomodule.core.interfaces.NativeMethodCallInvokerHol * class so that we may pass it from CatalystInstance, through Java, to * TurboModuleManager::initHybrid. */ +@Nullsafe(Nullsafe.Mode.LOCAL) @FrameworkAPI public class NativeMethodCallInvokerHolderImpl implements NativeMethodCallInvokerHolder {