mirror of
https://github.com/facebook/react-native.git
synced 2025-11-01 09:14:26 +00:00
onAnimatedValueUpdate should also include offset
Summary: Native Android implementation of animation listeners reports value only, and does not include offset. For non-native animation, the JavaScript listeners receive the animated node value + the animated node offset. Here's where the JavaScript node calls the listeners: https://github.com/facebook/react-native/blob/046f600cc23ff2d4aeb57be8e5606347f19b76d2/Libraries/Animated/src/AnimatedImplementation.js#L942 and here's how `__getValue()` is calculated: https://github.com/facebook/react-native/blob/046f600cc23ff2d4aeb57be8e5606347f19b76d2/Libraries/Animated/src/AnimatedImplementation.js#L741-L743 cc janicduplessis kmagiera Closes https://github.com/facebook/react-native/pull/15500 Differential Revision: D5638336 Pulled By: shergin fbshipit-source-id: d2104fdb483d9db3b856d625d021cceaa9232787
This commit is contained in:
committed by
Facebook Github Bot
parent
c2b3ee789c
commit
d0669fc922
@@ -49,7 +49,7 @@ import javax.annotation.Nullable;
|
||||
if (mValueListener == null) {
|
||||
return;
|
||||
}
|
||||
mValueListener.onValueUpdate(mValue);
|
||||
mValueListener.onValueUpdate(getValue());
|
||||
}
|
||||
|
||||
public void setValueListener(@Nullable AnimatedNodeValueListener listener) {
|
||||
|
||||
Reference in New Issue
Block a user