From cf717ffc19d1e4147502f5532650a8ce6453acaf Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 5 Aug 2021 18:34:22 -0700 Subject: [PATCH] Add TODOs to unify component names between JS - Android - iOS - C++ Summary: EZ diff that adds a few TODOs to unify component names between JS - Android - iOS - C++ see task: T97384889 changelog: [internal] internal Reviewed By: sammy-SC Differential Revision: D30139942 fbshipit-source-id: 91f51d04e7e7ecba7f059f94a121be43d820647d --- .../java/com/facebook/react/fabric/FabricComponents.java | 6 +++--- .../componentregistry/componentNameByReactViewName.cpp | 1 + 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricComponents.java b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricComponents.java index eca177237c3..73d2c6f59bf 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricComponents.java +++ b/ReactAndroid/src/main/java/com/facebook/react/fabric/FabricComponents.java @@ -14,15 +14,15 @@ import java.util.Map; /** * Utility class for Fabric components, this will be removed * - *

//TODO T31905686: remove this class when the component names are unified between JS - Android - * - iOS - C++ + *

TODO T97384889: remove this class when the component names are unified between JS - Android - + * iOS - C++ */ public class FabricComponents { private static @NonNull final Map sComponentNames = new HashMap<>(); static { - // TODO T31905686: unify component names between JS - Android - iOS - C++ + // TODO T97384889: unify component names between JS - Android - iOS - C++ sComponentNames.put("View", "RCTView"); sComponentNames.put("Image", "RCTImageView"); sComponentNames.put("ScrollView", "RCTScrollView"); diff --git a/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.cpp b/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.cpp index 6ad7a8ebc63..d920adccdc3 100644 --- a/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.cpp +++ b/ReactCommon/react/renderer/componentregistry/componentNameByReactViewName.cpp @@ -14,6 +14,7 @@ std::string componentNameByReactViewName(std::string viewName) { // We need this function only for the transition period; // eventually, all names will be unified. + // TODO T97384889: unify component names between JS - Android - iOS - C++ std::string rctPrefix("RCT"); if (std::mismatch(rctPrefix.begin(), rctPrefix.end(), viewName.begin()) .first == rctPrefix.end()) {