Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Extend Binding to log only when a MC is enabled

Browse Source 
Summary:
This diff integrates the logging of Binding class using a MC

changelog: [Internal] Internal change to control logging of Fabric

Reviewed By: JoshuaGross

Differential Revision: D21574813

fbshipit-source-id: e7b2acbaa4cb8a8e748db91af5c6960cd47b520e
This commit is contained in:
David Vacca
2020-05-14 21:40:11 -07:00
committed by Facebook GitHub Bot
parent 756eec6cf5
commit cf171e4e04
2 changed files with 24 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.cpp
+23 -10
View File
@@ -106,8 +106,11 @@ void Binding::startSurfaceWithConstraints(
jboolean doLeftAndRightSwapInRTL) {
SystraceSection s("FabricUIManagerBinding::startSurfaceWithConstraints");
LOG(WARNING) << "Binding::startSurfaceWithConstraints() was called (address: "
<< this << ", surfaceId: " << surfaceId << ").";
if (enableFabricLogs_) {
LOG(WARNING)
<< "Binding::startSurfaceWithConstraints() was called (address: "
<< this << ", surfaceId: " << surfaceId << ").";
}
std::shared_ptr<Scheduler> scheduler = getScheduler();
if (!scheduler) {
@@ -155,8 +158,10 @@ void Binding::renderTemplateToSurface(jint surfaceId, jstring uiTemplate) {
void Binding::stopSurface(jint surfaceId) {
SystraceSection s("FabricUIManagerBinding::stopSurface");
LOG(WARNING) << "Binding::stopSurface() was called (address: " << this
<< ", surfaceId: " << surfaceId << ").";
if (enableFabricLogs_) {
LOG(WARNING) << "Binding::stopSurface() was called (address: " << this
<< ", surfaceId: " << surfaceId << ").";
}
std::shared_ptr<Scheduler> scheduler = getScheduler();
if (!scheduler) {
@@ -209,8 +214,16 @@ void Binding::installFabricUIManager(
jni::alias_ref<jobject> reactNativeConfig) {
SystraceSection s("FabricUIManagerBinding::installFabricUIManager");
LOG(WARNING) << "Binding::installFabricUIManager() was called (address: "
<< this << ").";
std::shared_ptr<const ReactNativeConfig> config =
std::make_shared<const ReactNativeConfigHolder>(reactNativeConfig);
enableFabricLogs_ =
config->getBool("react_fabric:enabled_android_fabric_logs");
if (enableFabricLogs_) {
LOG(WARNING) << "Binding::installFabricUIManager() was called (address: "
<< this << ").";
}
// Use std::lock and std::adopt_lock to prevent deadlocks by locking mutexes
// at the same time
@@ -253,8 +266,6 @@ void Binding::installFabricUIManager(
ownerBox, eventBeatManager, runtimeExecutor, localJavaUIManager);
};
std::shared_ptr<const ReactNativeConfig> config =
std::make_shared<const ReactNativeConfigHolder>(reactNativeConfig);
contextContainer->insert("ReactNativeConfig", config);
contextContainer->insert("FabricUIManager", javaUIManager_);
@@ -281,8 +292,10 @@ void Binding::installFabricUIManager(
}
void Binding::uninstallFabricUIManager() {
LOG(WARNING) << "Binding::uninstallFabricUIManager() was called (address: "
<< this << ").";
if (enableFabricLogs_) {
LOG(WARNING) << "Binding::uninstallFabricUIManager() was called (address: "
<< this << ").";
}
// Use std::lock and std::adopt_lock to prevent deadlocks by locking mutexes
// at the same time
std::lock(schedulerMutex_, javaUIManagerMutex_);
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/Binding.h
+1
View File
@@ -112,6 +112,7 @@ class Binding : public jni::HybridClass<Binding>, public SchedulerDelegate {
bool collapseDeleteCreateMountingInstructions_{false};
bool disablePreallocateViews_{false};
bool disableVirtualNodePreallocation_{false};
bool enableFabricLogs_{false};
};
} // namespace react