From cec0de8f991fa65f832cdaf92188e501fb285d8f Mon Sep 17 00:00:00 2001 From: Joe Vilches Date: Wed, 2 Jul 2025 22:13:16 -0700 Subject: [PATCH] Change Scroller getter to protected (#52387) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52387 I would like to grab this in a subclass but unfortunately can't. It is kinda jank since this is a val obtained via reflection, but I figure this is better than copy and paste. I think that I could also expose a function that uses this scroller the way I want it to. Let me know if there are strong objections here Changelog: [Internal] Reviewed By: rozele Differential Revision: D77684599 fbshipit-source-id: 6f02c1da5135c1cf34fa1483542e06bf8f0be75e --- packages/react-native/ReactAndroid/api/ReactAndroid.api | 1 + .../java/com/facebook/react/views/scroll/ReactScrollView.java | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 10fd8fe8d60..6b3b6ce18de 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -5746,6 +5746,7 @@ public class com/facebook/react/views/scroll/ReactScrollView : android/widget/Sc public fun getFlingAnimator ()Landroid/animation/ValueAnimator; public fun getFlingExtrapolatedDistance (I)I public fun getLastScrollDispatchTime ()J + protected fun getOverScrollerFromParent ()Landroid/widget/OverScroller; public fun getOverflow ()Ljava/lang/String; public fun getOverflowInset ()Landroid/graphics/Rect; public fun getPointerEvents ()Lcom/facebook/react/uimanager/PointerEvents; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java index dd911975ca9..f708543cf45 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java @@ -165,7 +165,7 @@ public class ReactScrollView extends ScrollView } @Nullable - private OverScroller getOverScrollerFromParent() { + protected OverScroller getOverScrollerFromParent() { OverScroller scroller; if (!sTriedToGetScrollerField) {