From cebc2c9d3e5c3ba02313242ff11f0c1600e080fc Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Tue, 18 Feb 2020 03:38:50 -0800 Subject: [PATCH] Do not switch queues if not necessary Summary: Changelog: [Internal] Switching queue here is not necessary if we are already on the main queue. This is important for Fabric SSTs, otherwise images are missing. Reviewed By: shergin Differential Revision: D19907908 fbshipit-source-id: 52e82484afc8e2f591d0c5cc126952990d992e96 --- React/Fabric/RCTImageResponseObserverProxy.mm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/React/Fabric/RCTImageResponseObserverProxy.mm b/React/Fabric/RCTImageResponseObserverProxy.mm index bc97da889ad..9bb1e323fd3 100644 --- a/React/Fabric/RCTImageResponseObserverProxy.mm +++ b/React/Fabric/RCTImageResponseObserverProxy.mm @@ -7,6 +7,7 @@ #import "RCTImageResponseObserverProxy.h" +#import #import #import #import @@ -24,7 +25,7 @@ void RCTImageResponseObserverProxy::didReceiveImage(ImageResponse const &imageRe UIImage *image = (UIImage *)unwrapManagedObject(imageResponse.getImage()); id delegate = delegate_; auto this_ = this; - dispatch_async(dispatch_get_main_queue(), ^{ + RCTExecuteOnMainQueue(^{ [delegate didReceiveImage:image fromObserver:this_]; }); } @@ -33,7 +34,7 @@ void RCTImageResponseObserverProxy::didReceiveProgress(float progress) const { auto this_ = this; id delegate = delegate_; - dispatch_async(dispatch_get_main_queue(), ^{ + RCTExecuteOnMainQueue(^{ [delegate didReceiveProgress:progress fromObserver:this_]; }); } @@ -42,7 +43,7 @@ void RCTImageResponseObserverProxy::didReceiveFailure() const { auto this_ = this; id delegate = delegate_; - dispatch_async(dispatch_get_main_queue(), ^{ + RCTExecuteOnMainQueue(^{ [delegate didReceiveFailureFromObserver:this_]; }); }