From ceb6c3de54bbf053d4b4fbe9fac7f745fbf55d89 Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Tue, 2 Jun 2020 13:40:47 -0700 Subject: [PATCH] Fix assertions Summary: Changelog: [Internal][Fixed] - Fix non-null assertions These assertions weren't asserting that these objects aren't null. Reviewed By: mdvacca Differential Revision: D21844260 fbshipit-source-id: 6102fb304ddb6db61411e15c32355e4c3d3effca --- .../facebook/react/uimanager/DisplayMetricsHolder.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/DisplayMetricsHolder.java b/ReactAndroid/src/main/java/com/facebook/react/uimanager/DisplayMetricsHolder.java index ab6d1739b05..92b4e414d22 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/uimanager/DisplayMetricsHolder.java +++ b/ReactAndroid/src/main/java/com/facebook/react/uimanager/DisplayMetricsHolder.java @@ -104,8 +104,8 @@ public class DisplayMetricsHolder { } public static Map> getDisplayMetricsMap(double fontScale) { - Assertions.assertNotNull( - sWindowDisplayMetrics != null || sScreenDisplayMetrics != null, + Assertions.assertCondition( + sWindowDisplayMetrics != null && sScreenDisplayMetrics != null, "DisplayMetricsHolder must be initialized with initDisplayMetricsIfNotInitialized or initDisplayMetrics"); final Map> result = new HashMap<>(); result.put("windowPhysicalPixels", getPhysicalPixelsMap(sWindowDisplayMetrics, fontScale)); @@ -114,8 +114,8 @@ public class DisplayMetricsHolder { } public static WritableNativeMap getDisplayMetricsNativeMap(double fontScale) { - Assertions.assertNotNull( - sWindowDisplayMetrics != null || sScreenDisplayMetrics != null, + Assertions.assertCondition( + sWindowDisplayMetrics != null && sScreenDisplayMetrics != null, "DisplayMetricsHolder must be initialized with initDisplayMetricsIfNotInitialized or initDisplayMetrics"); final WritableNativeMap result = new WritableNativeMap(); result.putMap(