From cea0a2b61ae9bec5ceff697d8173d34cad438216 Mon Sep 17 00:00:00 2001 From: nossbigg Date: Wed, 22 May 2019 05:33:22 -0700 Subject: [PATCH] Set duration=0 for android keyboard events (#24994) Summary: Set duration=0 for android keyboard events. Brings actual implementation closer to existing flowtypes, and duration is set to 0 to minimize impact on existing keyboard event consumers. Follow up to #24947, upon cpojer's [input](https://github.com/facebook/react-native/pull/24947#issuecomment-494681618) :) ## Changelog [Android] [Added] - Set duration=0 for android keyboard events Pull Request resolved: https://github.com/facebook/react-native/pull/24994 Differential Revision: D15449394 Pulled By: cpojer fbshipit-source-id: d43096238bd38d189fbec54fc2d93f17010d9ddb --- Libraries/Components/Keyboard/Keyboard.js | 1 + ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java | 1 + 2 files changed, 2 insertions(+) diff --git a/Libraries/Components/Keyboard/Keyboard.js b/Libraries/Components/Keyboard/Keyboard.js index a7970fc8ed0..d4e99f51d8f 100644 --- a/Libraries/Components/Keyboard/Keyboard.js +++ b/Libraries/Components/Keyboard/Keyboard.js @@ -50,6 +50,7 @@ type BaseKeyboardEvent = {| export type AndroidKeyboardEvent = $ReadOnly<{| ...BaseKeyboardEvent, + duration: 0, easing: 'keyboard', |}>; diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java index 42d2c757ef2..37341ca9242 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java @@ -770,6 +770,7 @@ public class ReactRootView extends FrameLayout implements RootView, ReactRoot { keyboardEventParams.putMap("endCoordinates", endCoordinates); keyboardEventParams.putString("easing", "keyboard"); + keyboardEventParams.putDouble("duration", 0); return keyboardEventParams; } }