Breaking - remove unused registration of JS modules

Summary: It's now unnecessary to declare which JS modules you want to expose on your package. To upgrade, remove all overrides of `createJSModules` and keeping calling your JS modules as before.

Reviewed By: AaaChiuuu

Differential Revision: D5229259

fbshipit-source-id: 1160826c951433722f1fe0421c1200883ba1a348

ReactAndroid/src/androidTest/java/com/facebook/react/testing/ReactTestHelper.java

@@ -16,6 +16,7 @@ import android.support.test.InstrumentationRegistry;
 import android.view.View;
 import android.view.ViewGroup;
 
+import com.facebook.infer.annotation.Assertions;
 import com.facebook.react.NativeModuleRegistryBuilder;
 import com.facebook.react.R;
 import com.facebook.react.ReactInstanceManager;
@@ -39,8 +40,6 @@ public class ReactTestHelper {
   private static class DefaultReactTestFactory implements ReactTestFactory {
     private static class ReactInstanceEasyBuilderImpl implements ReactInstanceEasyBuilder {
 
-      private final JavaScriptModuleRegistry.Builder mJSModuleRegistryBuilder =
-        new JavaScriptModuleRegistry.Builder();
       private NativeModuleRegistryBuilder mNativeModuleRegistryBuilder;
 
       private @Nullable Context mContext;
@@ -59,16 +58,11 @@ public class ReactTestHelper {
             null,
             false);
         }
+        Assertions.assertNotNull(nativeModule);
         mNativeModuleRegistryBuilder.addNativeModule(nativeModule);
         return this;
       }
 
-      @Override
-      public ReactInstanceEasyBuilder addJSModule(Class moduleInterfaceClass) {
-        mJSModuleRegistryBuilder.add(moduleInterfaceClass);
-        return this;
-      }
-
       @Override
       public CatalystInstance build() {
         if (mNativeModuleRegistryBuilder == null) {
@@ -87,7 +81,6 @@ public class ReactTestHelper {
           .setReactQueueConfigurationSpec(ReactQueueConfigurationSpec.createDefault())
           .setJSExecutor(executor)
           .setRegistry(mNativeModuleRegistryBuilder.build())
-          .setJSModuleRegistry(mJSModuleRegistryBuilder.build())
           .setJSBundleLoader(JSBundleLoader.createAssetLoader(
               mContext,
               "assets://AndroidTestBundle.js",
@@ -141,12 +134,6 @@ public class ReactTestHelper {
           return this;
         }
 
-        @Override
-        public ReactTestFactory.ReactInstanceEasyBuilder addJSModule(Class moduleInterfaceClass) {
-          builder.addJSModule(moduleInterfaceClass);
-          return this;
-        }
-
         @Override
         public CatalystInstance build() {
           final CatalystInstance instance = builder.build();