Add more clang tidy rules

Summary:
changelog: [internal]

Add more clang tidy rules to prevent common class of bugs.

Reviewed By: javache

Differential Revision: D39245194

fbshipit-source-id: 5521c5c4653d7005b96ebba494e810ba5075afbc
This commit is contained in:
Samuel Susla
2022-09-06 07:01:17 -07:00
committed by Facebook GitHub Bot
parent 010cdcdc19
commit ce50c43986
73 changed files with 411 additions and 330 deletions
@@ -24,7 +24,7 @@ std::string DebugStringConvertible::getDebugChildrenDescription(
options.depth++;
auto trailing = options.format ? std::string{"\n"} : std::string{""};
auto childrenString = std::string{""};
std::string childrenString;
for (auto const &child : getDebugChildren()) {
if (!child) {
@@ -50,7 +50,7 @@ std::string DebugStringConvertible::getDebugPropsDescription(
options.depth++;
auto propsString = std::string{""};
std::string propsString;
for (auto const &prop : getDebugProps()) {
if (!prop) {
@@ -116,11 +116,11 @@ std::string DebugStringConvertible::getDebugValue() const {
SharedDebugStringConvertibleList DebugStringConvertible::getDebugChildren()
const {
return SharedDebugStringConvertibleList();
return {};
}
SharedDebugStringConvertibleList DebugStringConvertible::getDebugProps() const {
return SharedDebugStringConvertibleList();
return {};
}
/*