Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix T54997838

Browse Source 
Summary:
Fixes T54997838 by preventing any view mutations during `onMeasure` calls.

There might still be places where this is possible, but this is where I'm seeing all the crashes currently.

See comments in ReactRootView for why views were mutated during onMeasure.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D18518591

fbshipit-source-id: 1406af8a6b0bfcc86f4cc5b451b3967f312dfd85
This commit is contained in:
Joshua Gross
2019-11-14 21:21:31 -08:00
committed by Facebook Github Bot
parent c54f5cf72a
commit ce226c1f28
4 changed files with 67 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java
+5
View File
@@ -828,6 +828,11 @@ public class UIManagerModule extends ReactContextBaseJavaModule
}
}
@Override
public void setAllowImmediateUIOperationExecution(boolean flag) {
// Noop outside of Fabric, call directly on FabricUIManager
}
/**
* Schedule a block to be executed on the UI thread. Useful if you need to execute view logic
* after all currently queued view updates have completed.