From cdbd01100bd07fb66207d32a91e565730f2378ef Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Thu, 3 Apr 2025 05:05:38 -0700 Subject: [PATCH] Pin cmake version to 3.31.6 (#50464) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/50464 Runners in GHA has been updated by github and they now ship with CMake 4.0. (actions/runner-images#11926) This version is not compatible with React Native, so we are pinning cmake to 3.36.1 ## Changelog: [Internal] - Pin cmake to 3.36.1 Reviewed By: cortinico Differential Revision: D72379834 fbshipit-source-id: ab09009102118e6590f02cf57fa6f9149482f62b --- .github/actions/build-hermesc-linux/action.yml | 6 +++++- .github/actions/build-hermesc-windows/action.yml | 3 +++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.github/actions/build-hermesc-linux/action.yml b/.github/actions/build-hermesc-linux/action.yml index 5c2298ea83b..0c90739d0a7 100644 --- a/.github/actions/build-hermesc-linux/action.yml +++ b/.github/actions/build-hermesc-linux/action.yml @@ -14,8 +14,12 @@ runs: shell: bash run: | sudo apt update - sudo apt install -y git openssh-client cmake build-essential \ + sudo apt install -y git openssh-client build-essential \ libreadline-dev libicu-dev jq zip python3 + + # Install cmake 3.28.3-1build7 + sudo apt-get install cmake=3.28.3-1build7 + sudo ln -sf /usr/bin/cmake /usr/local/bin/cmake - name: Restore Hermes workspace uses: ./.github/actions/restore-hermes-workspace - name: Linux cache diff --git a/.github/actions/build-hermesc-windows/action.yml b/.github/actions/build-hermesc-windows/action.yml index 1491b381201..7b80fbc9929 100644 --- a/.github/actions/build-hermesc-windows/action.yml +++ b/.github/actions/build-hermesc-windows/action.yml @@ -39,6 +39,9 @@ runs: New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\icu New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\deps New-Item -ItemType Directory -ErrorAction SilentlyContinue $Env:HERMES_WS_DIR\win64-bin + - name: Downgrade CMake + shell: powershell + run: choco install cmake --version 3.31.6 --force - name: Build HermesC for Windows shell: powershell run: |