diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCHeapCapture.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCHeapCapture.java index 142c961ade4..2880da77845 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCHeapCapture.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/JSCHeapCapture.java @@ -8,17 +8,16 @@ package com.facebook.react.devsupport; import androidx.annotation.Nullable; +import com.facebook.fbreact.specs.NativeJSCHeapCaptureSpec; import com.facebook.react.bridge.JavaScriptModule; import com.facebook.react.bridge.ReactApplicationContext; -import com.facebook.react.bridge.ReactContextBaseJavaModule; -import com.facebook.react.bridge.ReactMethod; import com.facebook.react.module.annotations.ReactModule; import java.io.File; // This module is being called only by Java via the static method "captureHeap" that // requires it to already be initialized, thus we eagerly initialize this module @ReactModule(name = JSCHeapCapture.TAG, needsEagerInit = true) -public class JSCHeapCapture extends ReactContextBaseJavaModule { +public class JSCHeapCapture extends NativeJSCHeapCaptureSpec { public static final String TAG = "JSCHeapCapture"; public interface HeapCapture extends JavaScriptModule { @@ -69,7 +68,7 @@ public class JSCHeapCapture extends ReactContextBaseJavaModule { } } - @ReactMethod + @Override public synchronized void captureComplete(String path, String error) { if (mCaptureInProgress != null) { if (error == null) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/LogBoxModule.java b/ReactAndroid/src/main/java/com/facebook/react/devsupport/LogBoxModule.java index 05e70b069d3..9050a421fb4 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/devsupport/LogBoxModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/devsupport/LogBoxModule.java @@ -12,16 +12,15 @@ import android.view.View; import android.view.ViewGroup; import androidx.annotation.Nullable; import com.facebook.common.logging.FLog; +import com.facebook.fbreact.specs.NativeLogBoxSpec; import com.facebook.react.bridge.ReactApplicationContext; -import com.facebook.react.bridge.ReactContextBaseJavaModule; -import com.facebook.react.bridge.ReactMethod; import com.facebook.react.bridge.UiThreadUtil; import com.facebook.react.common.ReactConstants; import com.facebook.react.devsupport.interfaces.DevSupportManager; import com.facebook.react.module.annotations.ReactModule; @ReactModule(name = LogBoxModule.NAME) -public class LogBoxModule extends ReactContextBaseJavaModule { +public class LogBoxModule extends NativeLogBoxSpec { public static final String NAME = "LogBox"; @@ -54,7 +53,7 @@ public class LogBoxModule extends ReactContextBaseJavaModule { return NAME; } - @ReactMethod + @Override public void show() { UiThreadUtil.runOnUiThread( new Runnable() { @@ -77,7 +76,7 @@ public class LogBoxModule extends ReactContextBaseJavaModule { }); } - @ReactMethod + @Override public void hide() { UiThreadUtil.runOnUiThread( new Runnable() {