Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix bottom sheet in Fabric Android

Browse Source 
Summary: This diff fixes the rendering of Bottom Sheet in Fabric Android. In D15343702 we added state as part of the "preallocateView" method but we forgot to call viewManager.updateState(), this prevents the state to be updated during the first render.

Reviewed By: shergin

Differential Revision: D15476042

fbshipit-source-id: cd6fc9bdd178589d2e04f85723425b5e5c3e5a04
This commit is contained in:
David Vacca
2019-05-24 11:30:30 -07:00
committed by Facebook Github Bot
parent c629cdc39a
commit cd5fe06abe
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountingManager.java
+3
View File
@@ -193,6 +193,9 @@ public class MountingManager {
viewManager = mViewManagerRegistry.get(componentName);
view = mViewFactory.getOrCreateView(componentName, propsDiffMap, stateWrapper, themedReactContext);
view.setId(reactTag);
if (stateWrapper != null) {
viewManager.updateState(view, stateWrapper);
}
}
ViewState viewState = new ViewState(reactTag, view, viewManager);