From cd5991c64830780a54eb86f2e490208d919cf652 Mon Sep 17 00:00:00 2001 From: generatedunixname89002005287564 Date: Thu, 17 Apr 2025 11:59:57 -0700 Subject: [PATCH] Fix CQS signal. Id] 19045409 -- readability-redundant-string-init in xplat/js/react-native-github/packages/react-native/ReactCommon/react/renderer/components/view Reviewed By: dtolnay Differential Revision: D73175242 fbshipit-source-id: 4f79d0f661a15fda883eb9f03c42040da9a740c8 --- .../components/view/AccessibilityPrimitives.h | 2 +- .../renderer/components/view/AccessibilityProps.h | 12 ++++++------ 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityPrimitives.h b/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityPrimitives.h index 420a10852af..73d0dd8e778 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityPrimitives.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityPrimitives.h @@ -49,7 +49,7 @@ constexpr enum AccessibilityTraits operator&( } struct AccessibilityAction { - std::string name{""}; + std::string name; std::optional label{}; }; diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.h b/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.h index 6583ec389b4..c0f8c3bbcfd 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/AccessibilityProps.h @@ -33,16 +33,16 @@ class AccessibilityProps { bool accessible{false}; std::optional accessibilityState{std::nullopt}; - std::string accessibilityLabel{""}; + std::string accessibilityLabel; std::vector accessibilityOrder{}; AccessibilityLabelledBy accessibilityLabelledBy{}; AccessibilityLiveRegion accessibilityLiveRegion{ AccessibilityLiveRegion::None}; AccessibilityTraits accessibilityTraits{AccessibilityTraits::None}; - std::string accessibilityRole{""}; - std::string accessibilityHint{""}; - std::string accessibilityLanguage{""}; - std::string accessibilityLargeContentTitle{""}; + std::string accessibilityRole; + std::string accessibilityHint; + std::string accessibilityLanguage; + std::string accessibilityLargeContentTitle; AccessibilityValue accessibilityValue; std::vector accessibilityActions{}; bool accessibilityShowsLargeContentViewer{false}; @@ -56,7 +56,7 @@ class AccessibilityProps { ImportantForAccessibility importantForAccessibility{ ImportantForAccessibility::Auto}; Role role{Role::None}; - std::string testId{""}; + std::string testId; #pragma mark - DebugStringConvertible