From ccfd4c080ccaf9b030dbd6f3f5a3242b457db8be Mon Sep 17 00:00:00 2001 From: Phillip Pan Date: Sat, 16 Sep 2023 01:35:01 -0700 Subject: [PATCH] deprecate hasConstants from ReactModule annotation (#39489) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/39489 ## Changelog [Android][Deprecated] - deprecate hasConstants from ReactModule annotation this is not used in our framework anymore, deprecating Reviewed By: cortinico Differential Revision: D49262867 fbshipit-source-id: 90e5ee75cf20345c6121e77a3328f9c96f104cdb --- .../com/facebook/react/module/annotations/ReactModule.java | 4 ++++ .../com/facebook/react/modules/websocket/WebSocketModule.java | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/annotations/ReactModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/annotations/ReactModule.java index 0c9187982f8..14bea35dc6e 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/annotations/ReactModule.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/module/annotations/ReactModule.java @@ -16,6 +16,9 @@ import java.lang.annotation.Target; /** * Annotation for use on {@link com.facebook.react.bridge.BaseJavaModule}s to describe properties * for that module. + * + * @deprecated This property is unused and it's planning to be removed in a future version of React + * Native. Please refrain from using it. */ @Retention(RUNTIME) @Target(TYPE) @@ -38,6 +41,7 @@ public @interface ReactModule { * Whether this module has constants to add, defaults to true as that is safer for when a correct * annotation is not included */ + @Deprecated boolean hasConstants() default true; /** diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java index d13db1fb2a9..6d7f4de23ee 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/websocket/WebSocketModule.java @@ -36,7 +36,7 @@ import okhttp3.WebSocket; import okhttp3.WebSocketListener; import okio.ByteString; -@ReactModule(name = NativeWebSocketModuleSpec.NAME, hasConstants = false) +@ReactModule(name = NativeWebSocketModuleSpec.NAME) public final class WebSocketModule extends NativeWebSocketModuleSpec { public interface ContentHandler { void onMessage(String text, WritableMap params);