Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fabric Picker Native Command support

Browse Source 
Summary:
This adds support for a controlled  `<Picker/>` component .

Changelog: [iOS][Fabric] Fabric Picker support

Reviewed By: sammy-SC

Differential Revision: D24005475

fbshipit-source-id: c50e9918f74f6ef5cdfbfe67cb6c132c12d64916
This commit is contained in:
Peter Argany
2020-10-13 11:19:29 -07:00
committed by Facebook GitHub Bot
parent 51e8e0b7e1
commit ccc4f0153d
1 changed files with 27 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
React/Fabric/Mounting/ComponentViews/Picker/RCTPickerComponentView.mm
+27 -1
View File
@@ -8,6 +8,7 @@
#import "RCTPickerComponentView.h"
#import <React/RCTConvert.h>
#import <React/RCTLog.h>
#import <UIKit/UIKit.h>
#import <react/renderer/components/iospicker/PickerComponentDescriptor.h>
#import <react/renderer/components/iospicker/PickerEventEmitter.h>
@@ -75,17 +76,21 @@ using namespace facebook::react;
{
const auto &oldPickerProps = *std::static_pointer_cast<const PickerProps>(_props);
const auto &newPickerProps = *std::static_pointer_cast<const PickerProps>(props);
bool needsToReload = false;
if (oldPickerProps.items != newPickerProps.items) {
_items = newPickerProps.items;
needsToReload = true;
}
if (oldPickerProps.selectedIndex != newPickerProps.selectedIndex) {
_selectedIndex = newPickerProps.selectedIndex;
[self setSelectedIndex];
}
if (oldPickerProps.textAttributes != newPickerProps.textAttributes) {
_textAttributes = RCTNSTextAttributesFromTextAttributes(newPickerProps.getEffectiveTextAttributes());
needsToReload = true;
}
// TODO (T75217510) - Figure out testID.
@@ -96,12 +101,33 @@ using namespace facebook::react;
_accessibilityLabel = [NSString stringWithUTF8String:newPickerProps.accessibilityLabel.c_str()];
}
if (needsToReload) {
[_pickerView reloadAllComponents];
}
[super updateProps:props oldProps:oldProps];
}
// TODO (T75217510) - Handle Native Commands
#pragma mark - Native Commands
- (void)handleCommand:(const NSString *)commandName args:(const NSArray *)args
{
if ([commandName isEqualToString:@"setNativeSelectedIndex"] && [args objectAtIndex:0]) {
NSNumber *selectedIndex = [args objectAtIndex:0];
if (_selectedIndex != selectedIndex.integerValue) {
[self setSelectedIndex];
}
} else {
RCTLogWarn(@"Attempting to send unknown command to Picker component: %@", commandName);
}
}
- (void)setSelectedIndex
{
BOOL animated = _selectedIndex != NSNotFound; // Don't animate the initial value.
[_pickerView selectRow:_selectedIndex inComponent:0 animated:animated];
}
#pragma mark - UIPickerViewDataSource protocol
- (NSInteger)numberOfComponentsInPickerView:(__unused UIPickerView *)pickerView