From cc2a73aa4d51e3256e62b7269e3d48bf74beee3e Mon Sep 17 00:00:00 2001 From: David Vacca Date: Wed, 14 Feb 2024 00:00:48 -0800 Subject: [PATCH] Revert initialization of event emits during initial rendering in Fabric Summary: Original commit changeset: 0b56b7495db6 Original Phabricator Diff: D53108114 bypass-github-export-checks changelog: [internal] internal Reviewed By: philIip Differential Revision: D53746331 fbshipit-source-id: 95daf5660845eb9a5dd84da85833727aed4e65e3 --- .../java/com/facebook/react/views/text/TextAttributes.java | 1 - .../src/main/jni/react/fabric/FabricMountingManager.cpp | 5 ----- 2 files changed, 6 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributes.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributes.java index 0bcbce4a0ad..de72c0e3914 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributes.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/TextAttributes.java @@ -177,7 +177,6 @@ public class TextAttributes { : DEFAULT_MAX_FONT_SIZE_MULTIPLIER; } - @Override public String toString() { return ("TextAttributes {" + "\n getAllowFontScaling(): " diff --git a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp index c34ba932595..2a459f77167 100644 --- a/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp +++ b/packages/react-native/ReactAndroid/src/main/jni/react/fabric/FabricMountingManager.cpp @@ -810,11 +810,6 @@ void FabricMountingManager::preallocateShadowView( // Do not hold a reference to javaEventEmitter from the C++ side. jni::local_ref javaEventEmitter = nullptr; - SharedEventEmitter eventEmitter = shadowView.eventEmitter; - if (eventEmitter != nullptr) { - javaEventEmitter = - EventEmitterWrapper::newObjectCxxArgs(shadowView.eventEmitter); - } jni::local_ref props = getProps({}, shadowView);