From cc13060d70cb55650f621ea75d01dabf38962850 Mon Sep 17 00:00:00 2001 From: Sandeep Raghunandhan Date: Thu, 22 Jul 2021 20:33:55 -0700 Subject: [PATCH] Downgrade warning of view illegally being added to parent to Soft Exception Summary: - This is crashing too much in debug, which is good signal but making it harder to test, and test unrelated features. Reviewed By: JoshuaGross Differential Revision: D29857626 fbshipit-source-id: c52cfb6131747ae420b27de0591620fe79f47359 --- .../src/main/java/com/facebook/react/ReactRootView.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java index 2819e7e2af1..eb4fddfeb80 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java @@ -35,6 +35,7 @@ import com.facebook.react.bridge.CatalystInstance; import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReactMarker; import com.facebook.react.bridge.ReactMarkerConstants; +import com.facebook.react.bridge.ReactNoCrashSoftException; import com.facebook.react.bridge.ReactSoftException; import com.facebook.react.bridge.UIManager; import com.facebook.react.bridge.UiThreadUtil; @@ -342,7 +343,7 @@ public class ReactRootView extends FrameLayout implements RootView, ReactRoot { if (!child.isShown()) { ReactSoftException.logSoftException( TAG, - new IllegalViewOperationException( + new ReactNoCrashSoftException( "A view was illegally added as a child of a ReactRootView. " + "This View should not be a direct child of a ReactRootView, because it is not visible and will never be reachable. Child: " + child.getClass().getCanonicalName().toString()