From cbf11699d9d1b01b1cd8ba95cf5b7840aa7b7fde Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Mateo=20Guzm=C3=A1n?= Date: Mon, 7 Apr 2025 03:37:19 -0700 Subject: [PATCH] Make `ViewGroupClickEvent` internal (#50505) Summary: This class can be internalized as part of the initiative to reduce the public API surface. I've checked there are [no relevant OSS usages](https://github.com/search?type=code&q=NOT+is%3Afork+NOT+org%3Afacebook+NOT+repo%3Areact-native-tvos%2Freact-native-tvos+NOT+repo%3Anuagoz%2Freact-native+NOT+repo%3A2lambda123%2Freact-native+NOT+repo%3Abeanchips%2Ffacebookreactnative+NOT+repo%3AfabOnReact%2Freact-native-notes+NOT+user%3Ahuntie+NOT+user%3Acortinico+NOT+repo%3AMaxdev18%2Fpowersync_app+NOT+repo%3Acarter-0%2Finstagram-decompiled+NOT+repo%3Am0mosenpai%2Finstadamn+NOT+repo%3AA-Star100%2FA-Star100-AUG2-2024+NOT+repo%3Alclnrd%2Fdetox-scrollview-reproductible+NOT+repo%3ADionisisChytiris%2FWorldWiseTrivia_Main+NOT+repo%3Apast3l%2Fhi2+NOT+repo%3AoneDotpy%2FCaribouQuest+NOT+repo%3Abejayoharen%2Fdailytodo+NOT+repo%3Amolangning%2Freversing-discord+NOT+repo%3AScottPrzy%2Freact-native+NOT+repo%3Agabrieldonadel%2Freact-native-visionos+NOT+repo%3AGabriel2308%2FTestes-Soft+NOT+repo%3Adawnzs03%2FflakyBuild+NOT+repo%3Acga2351%2Fcode+NOT+repo%3Astreeg%2Ftcc+NOT+repo%3Asoftware-mansion-labs%2Freact-native-swiftui+NOT+repo%3Apkcsecurity%2Fdecompiled-lightbulb+com.facebook.react.views.view.ViewGroupClickEvent). ## Changelog: [INTERNAL] - Make com.facebook.react.views.view.ViewGroupClickEvent internal Pull Request resolved: https://github.com/facebook/react-native/pull/50505 Test Plan: ```bash yarn test-android yarn android ``` Reviewed By: cortinico Differential Revision: D72549704 Pulled By: javache fbshipit-source-id: 8c90192bc088ab52e709e87870eb1c2353cf1e85 --- packages/react-native/ReactAndroid/api/ReactAndroid.api | 7 ------- .../com/facebook/react/views/view/ViewGroupClickEvent.kt | 8 ++++---- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 60f55a8185a..73e232a5c65 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -7225,10 +7225,3 @@ public class com/facebook/react/views/view/ReactViewManager : com/facebook/react public final class com/facebook/react/views/view/ReactViewManager$Companion { } -public final class com/facebook/react/views/view/ViewGroupClickEvent : com/facebook/react/uimanager/events/Event { - public fun (I)V - public fun (II)V - public fun canCoalesce ()Z - public fun getEventName ()Ljava/lang/String; -} - diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ViewGroupClickEvent.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ViewGroupClickEvent.kt index 0fc3ad302e4..c0eb9d4a7d1 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ViewGroupClickEvent.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/view/ViewGroupClickEvent.kt @@ -13,15 +13,15 @@ import com.facebook.react.uimanager.common.ViewUtil import com.facebook.react.uimanager.events.Event /** Represents a Click on the ReactViewGroup */ -public class ViewGroupClickEvent(surfaceId: Int, viewId: Int) : +internal class ViewGroupClickEvent(surfaceId: Int, viewId: Int) : Event(surfaceId, viewId) { @Deprecated("Use the constructor with surfaceId and viewId parameters.") - public constructor(viewId: Int) : this(ViewUtil.NO_SURFACE_ID, viewId) + constructor(viewId: Int) : this(ViewUtil.NO_SURFACE_ID, viewId) - public override fun getEventName(): String = EVENT_NAME + override fun getEventName(): String = EVENT_NAME - public override fun canCoalesce(): Boolean = false + override fun canCoalesce(): Boolean = false protected override fun getEventData(): WritableMap = Arguments.createMap()