Facebook/react-native
1
0 Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename ReactSoftException to ReactSoftExceptionLogger

Browse Source 
Summary:
ReactSoftException makes it seem like the class is an Exception, when it's actually a logger. This rename I think is more appropriate.

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D30251735

fbshipit-source-id: 550bd543388e698774ec31753200bd3f722d8c17
This commit is contained in:
Ramanpreet Nara authored and Facebook GitHub Bot committed 2021-08-11 13:29:42 -07:00
1 parent 56dcc6ea55
commit cbec66ef92
28 files changed
+91 -88
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

ReactAndroid/src/main/java/com/facebook/react/uimanager/UIViewOperationQueue.java
+6 -5
View File
@@ -18,7 +18,7 @@ import com.facebook.react.bridge.GuardedRunnable;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReactNoCrashSoftException;
import com.facebook.react.bridge.ReactSoftException;
import com.facebook.react.bridge.ReactSoftExceptionLogger;
import com.facebook.react.bridge.ReadableArray;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.bridge.RetryableMountingLayerException;
@@ -313,7 +313,7 @@ public class UIViewOperationQueue {
try {
mNativeViewHierarchyManager.dispatchCommand(mTag, mCommand, mArgs);
} catch (Throwable e) {
ReactSoftException.logSoftException(
ReactSoftExceptionLogger.logSoftException(
TAG, new RuntimeException("Error dispatching View Command", e));
}
}
@@ -354,7 +354,7 @@ public class UIViewOperationQueue {
try {
mNativeViewHierarchyManager.dispatchCommand(mTag, mCommand, mArgs);
} catch (Throwable e) {
ReactSoftException.logSoftException(
ReactSoftExceptionLogger.logSoftException(
TAG, new RuntimeException("Error dispatching View Command", e));
}
}
@@ -892,11 +892,12 @@ public class UIViewOperationQueue {
mViewCommandOperations.add(op);
} else {
// Retryable exceptions should be logged, but never crash in debug.
ReactSoftException.logSoftException(TAG, new ReactNoCrashSoftException(e));
ReactSoftExceptionLogger.logSoftException(
TAG, new ReactNoCrashSoftException(e));
}
} catch (Throwable e) {
// Non-retryable exceptions should be logged in prod, and crash in Debug.
ReactSoftException.logSoftException(TAG, e);
ReactSoftExceptionLogger.logSoftException(TAG, e);
}
}
}