Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename ReactSoftException to ReactSoftExceptionLogger

Browse Source 
Summary:
ReactSoftException makes it seem like the class is an Exception, when it's actually a logger. This rename I think is more appropriate.

Changelog: [Internal]

Reviewed By: JoshuaGross

Differential Revision: D30251735

fbshipit-source-id: 550bd543388e698774ec31753200bd3f722d8c17
This commit is contained in:
Ramanpreet Nara
2021-08-11 13:28:16 -07:00
committed by Facebook GitHub Bot
parent 56dcc6ea55
commit cbec66ef92
28 changed files with 91 additions and 88 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/ReactRootView.java
+3 -3
View File
@@ -36,7 +36,7 @@ import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReactMarker;
import com.facebook.react.bridge.ReactMarkerConstants;
import com.facebook.react.bridge.ReactNoCrashSoftException;
import com.facebook.react.bridge.ReactSoftException;
import com.facebook.react.bridge.ReactSoftExceptionLogger;
import com.facebook.react.bridge.UIManager;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.bridge.WritableMap;
@@ -341,7 +341,7 @@ public class ReactRootView extends FrameLayout implements RootView, ReactRoot {
@Override
public void run() {
if (!child.isShown()) {
ReactSoftException.logSoftException(
ReactSoftExceptionLogger.logSoftException(
TAG,
new ReactNoCrashSoftException(
"A view was illegally added as a child of a ReactRootView. "
@@ -529,7 +529,7 @@ public class ReactRootView extends FrameLayout implements RootView, ReactRoot {
removeAllViews();
if (surfaceId == NO_ID) {
ReactSoftException.logSoftException(
ReactSoftExceptionLogger.logSoftException(
TAG,
new RuntimeException(
"unmountReactApplication called on ReactRootView with invalid id"));