From cb49dfe32503f73883c4aeec58e35f6436637df3 Mon Sep 17 00:00:00 2001 From: Andrew Datsenko Date: Mon, 29 Jul 2024 06:34:25 -0700 Subject: [PATCH] xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java (#45682) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45682 Changelog: [Internal] Reviewed By: cortinico Differential Revision: D60257806 fbshipit-source-id: 31fbcc257e383e2453dc6cc8db8efece9237e401 --- .../devsupport/ReleaseDevSupportManager.java | 40 +++++++++++-------- 1 file changed, 23 insertions(+), 17 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java index 94dd527db59..d0b8ff50b0b 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.java @@ -11,6 +11,7 @@ import android.app.Activity; import android.util.Pair; import android.view.View; import androidx.annotation.Nullable; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.react.bridge.DefaultJSExceptionHandler; import com.facebook.react.bridge.ReactContext; import com.facebook.react.bridge.ReadableArray; @@ -31,6 +32,7 @@ import java.io.File; * A dummy implementation of {@link DevSupportManager} to be used in production mode where * development features aren't needed. */ +@Nullsafe(Nullsafe.Mode.LOCAL) public class ReleaseDevSupportManager implements DevSupportManager { private final DefaultJSExceptionHandler mDefaultJSExceptionHandler; @@ -40,24 +42,27 @@ public class ReleaseDevSupportManager implements DevSupportManager { } @Override - public void showNewJavaError(String message, Throwable e) {} + public void showNewJavaError(@Nullable String message, @Nullable Throwable e) {} @Override - public void addCustomDevOption(String optionName, DevOptionHandler optionHandler) {} + public void addCustomDevOption( + @Nullable String optionName, @Nullable DevOptionHandler optionHandler) {} @Override - public void showNewJSError(String message, ReadableArray details, int errorCookie) {} + public void showNewJSError( + @Nullable String message, @Nullable ReadableArray details, int errorCookie) {} @Override - public @Nullable View createRootView(String appKey) { + public @Nullable View createRootView(@Nullable String appKey) { return null; } @Override - public void destroyRootView(View rootView) {} + public void destroyRootView(@Nullable View rootView) {} @Override - public void updateJSError(String message, ReadableArray details, int errorCookie) {} + public void updateJSError( + @Nullable String message, @Nullable ReadableArray details, int errorCookie) {} @Override public void hideRedboxDialog() {} @@ -92,12 +97,12 @@ public class ReleaseDevSupportManager implements DevSupportManager { } @Override - public DeveloperSettings getDevSettings() { + public @Nullable DeveloperSettings getDevSettings() { return null; } @Override - public RedBoxHandler getRedBoxHandler() { + public @Nullable RedBoxHandler getRedBoxHandler() { return null; } @@ -108,22 +113,22 @@ public class ReleaseDevSupportManager implements DevSupportManager { public void onReactInstanceDestroyed(ReactContext reactContext) {} @Override - public String getSourceMapUrl() { + public @Nullable String getSourceMapUrl() { return null; } @Override - public String getSourceUrl() { + public @Nullable String getSourceUrl() { return null; } @Override - public String getJSBundleURLForRemoteDebugging() { + public @Nullable String getJSBundleURLForRemoteDebugging() { return null; } @Override - public String getDownloadedJSBundleFile() { + public @Nullable String getDownloadedJSBundleFile() { return null; } @@ -151,7 +156,7 @@ public class ReleaseDevSupportManager implements DevSupportManager { @Override public @Nullable File downloadBundleResourceFromUrlSync( - final String resourceURL, final File outputFile) { + final String resourceURL, @Nullable final File outputFile) { return null; } @@ -176,16 +181,17 @@ public class ReleaseDevSupportManager implements DevSupportManager { } @Override - public void registerErrorCustomizer(ErrorCustomizer errorCustomizer) {} + public void registerErrorCustomizer(@Nullable ErrorCustomizer errorCustomizer) {} @Override - public Pair processErrorCustomizers(Pair errorInfo) { + public @Nullable Pair processErrorCustomizers( + @Nullable Pair errorInfo) { return errorInfo; } @Override public void setPackagerLocationCustomizer( - DevSupportManager.PackagerLocationCustomizer packagerLocationCustomizer) {} + @Nullable DevSupportManager.PackagerLocationCustomizer packagerLocationCustomizer) {} @Override public void handleException(Exception e) { @@ -198,7 +204,7 @@ public class ReleaseDevSupportManager implements DevSupportManager { } @Override - public @Nullable SurfaceDelegate createSurfaceDelegate(String moduleName) { + public @Nullable SurfaceDelegate createSurfaceDelegate(@Nullable String moduleName) { return null; }