Fabric: Storing commit revision number in MountingTelemetry

Summary:
Now we store a revision number of a Shadow Tree that leads to a transaction for which the concrete instance of MountingTelemetry corresponds. This is useful to understand how many actual transactions were skipped during a mounting phase (a mounting transaction does not directly correspond to a commit operation).

Changelog: [Internal] Fabric-specific internal change.

Reviewed By: mdvacca

Differential Revision: D23364663

fbshipit-source-id: 32b86bcdfc1ae97d8fff3b97a8615cc5a5b4d4a9
This commit is contained in:
Valentin Shergin
2020-08-27 12:31:42 -07:00
committed by Facebook GitHub Bot
parent dfa25df2cf
commit cb48b50290
7 changed files with 25 additions and 10 deletions
@@ -609,7 +609,8 @@ void Binding::schedulerDidFinishTransaction(
}
}
}
int64_t commitNumber = telemetry.getCommitNumber();
auto revisionNumber = telemetry.getRevisionNumber();
std::vector<local_ref<jobject>> queue;
// Upper bound estimation of mount items to be delivered to Java side.
@@ -813,7 +814,7 @@ void Binding::schedulerDidFinishTransaction(
surfaceId,
position == 0 ? nullptr : mountItemsArray.get(),
position,
commitNumber);
revisionNumber);
static auto scheduleMountItem =
jni::findClassStatic(Binding::UIManagerJavaDescriptor)
@@ -833,7 +834,7 @@ void Binding::schedulerDidFinishTransaction(
scheduleMountItem(
localJavaUIManager,
batch.get(),
telemetry.getCommitNumber(),
telemetry.getRevisionNumber(),
telemetryTimePointToMilliseconds(telemetry.getCommitStartTime()),
telemetryTimePointToMilliseconds(telemetry.getDiffStartTime()),
telemetryTimePointToMilliseconds(telemetry.getDiffEndTime()),