From ca9a55e28b60b807644210170e7bf3b4bb8e8a86 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Estev=C3=A3o=20Lucas?= Date: Mon, 29 Apr 2019 03:14:32 -0700 Subject: [PATCH] Remove `accessibilityTraits` prop (accessibility) (#24643) Summary: `accessibilityTraits` and `accessibilityComponentType` were removed on #24344. This PR removes `accessibilityTraits` prop from Fabric as well. [General] [Removed] - Remove `accessibilityTraits` prop from Fabric. Pull Request resolved: https://github.com/facebook/react-native/pull/24643 Differential Revision: D15120193 Pulled By: cpojer fbshipit-source-id: 98440ac447569c26205fc38b93ce2591ccf1a3cf --- .../Mounting/ComponentViews/View/RCTViewComponentView.mm | 6 ------ .../components/view/accessibility/AccessibilityProps.cpp | 4 ---- 2 files changed, 10 deletions(-) diff --git a/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm b/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm index 0317465f601..235ebf0f96d 100644 --- a/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm +++ b/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm @@ -221,12 +221,6 @@ using namespace facebook::react; self.accessibilityElement.accessibilityHint = RCTNSStringFromStringNilIfEmpty(newViewProps.accessibilityHint); } - // `accessibilityTraits` - if (oldViewProps.accessibilityTraits != newViewProps.accessibilityTraits) { - self.accessibilityElement.accessibilityTraits = - RCTUIAccessibilityTraitsFromAccessibilityTraits(newViewProps.accessibilityTraits); - } - // `accessibilityViewIsModal` if (oldViewProps.accessibilityViewIsModal != newViewProps.accessibilityViewIsModal) { self.accessibilityElement.accessibilityViewIsModal = newViewProps.accessibilityViewIsModal; diff --git a/ReactCommon/fabric/components/view/accessibility/AccessibilityProps.cpp b/ReactCommon/fabric/components/view/accessibility/AccessibilityProps.cpp index d464abe7e30..7e3d0275657 100644 --- a/ReactCommon/fabric/components/view/accessibility/AccessibilityProps.cpp +++ b/ReactCommon/fabric/components/view/accessibility/AccessibilityProps.cpp @@ -20,10 +20,6 @@ AccessibilityProps::AccessibilityProps( const RawProps &rawProps) : accessible( convertRawProp(rawProps, "accessible", sourceProps.accessible)), - accessibilityTraits(convertRawProp( - rawProps, - "accessibilityTraits", - sourceProps.accessibilityTraits)), accessibilityLabel(convertRawProp( rawProps, "accessibilityLabel",