From ca4aafffb3f4716e0cf77d4cf6e803a5638f52fb Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 11 May 2026 12:55:12 -0700 Subject: [PATCH] Rename use-hermes-nightly workflow input to use-hermes-prebuilt (#56756) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56756 The use-hermes-nightly boolean input of prebuild-ios-core.yml was misleadingly named. It controls whether to use the latest prebuilt Hermes from npm's latest-v1 dist-tag (not a 'nightly' build). Rename: - prebuild-ios-core.yml input: use-hermes-nightly -> use-hermes-prebuilt - Update description of the input - Update comment to move the TODO note inline - Update callers in nightly.yml and test-all.yml ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D104649628 fbshipit-source-id: 71c75b07caebfe5e7d03e80d47cefba883843c9a --- .github/workflows/nightly.yml | 2 +- .github/workflows/prebuild-ios-core.yml | 12 ++++++------ .github/workflows/test-all.yml | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/nightly.yml b/.github/workflows/nightly.yml index e471fb0b78b..ea3f97acced 100644 --- a/.github/workflows/nightly.yml +++ b/.github/workflows/nightly.yml @@ -29,7 +29,7 @@ jobs: prebuild_react_native_core: uses: ./.github/workflows/prebuild-ios-core.yml with: - use-hermes-nightly: true + use-hermes-prebuilt: true version-type: nightly secrets: inherit needs: [prebuild_apple_dependencies] diff --git a/.github/workflows/prebuild-ios-core.yml b/.github/workflows/prebuild-ios-core.yml index 6edd91afcd0..5e218f2a7f9 100644 --- a/.github/workflows/prebuild-ios-core.yml +++ b/.github/workflows/prebuild-ios-core.yml @@ -8,8 +8,8 @@ on: type: string required: false default: '' - use-hermes-nightly: - description: 'Whether to use the hermes nightly build or read the version from the versions.properties file' + use-hermes-prebuilt: + description: 'Whether to resolve Hermes from the latest-v1 npm dist-tag (true) or from the version pinned in version.properties (false)' type: boolean required: false default: false @@ -47,10 +47,10 @@ jobs: - name: Set Hermes version shell: bash run: | - # Nightly RN builds resolve Hermes from npm's latest-v1 dist-tag (TODO: - # rename to 'latest' once V1 is the only Hermes on npm). Stable builds - # use the version pinned in version.properties. - if [ "${{ inputs.use-hermes-nightly }}" == "true" ]; then + # Non-stable RN builds resolve Hermes from npm's latest-v1 dist-tag. + # TODO: rename 'latest-v1' to 'latest' once V1 is the only Hermes on npm. + # Stable builds use the version pinned in version.properties. + if [ "${{ inputs.use-hermes-prebuilt }}" == "true" ]; then HERMES_VERSION="latest-v1" else HERMES_VERSION=$(sed -n 's/^HERMES_VERSION_NAME=//p' packages/react-native/sdks/hermes-engine/version.properties) diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index 1406e9fd73a..09dad237c7b 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -100,7 +100,7 @@ jobs: prebuild_react_native_core: uses: ./.github/workflows/prebuild-ios-core.yml with: - use-hermes-nightly: ${{ !endsWith(github.ref_name, '-stable') }} + use-hermes-prebuilt: ${{ !endsWith(github.ref_name, '-stable') }} secrets: inherit needs: [prebuild_apple_dependencies]