From c99a0212a0abaeb47721b08f3ae50fffb4601e12 Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Fri, 8 Oct 2021 13:43:16 -0700 Subject: [PATCH] Fix failing assert in EventTarget Summary: changelog: [internal] calling `setEnabled(true)` needs to have a matching `setEnabled(false)` in order for `eventTarget_` to be deallocated correctly. Also, retaining `eventTarget_` longer, does not mean instanceHandle will be available later on. Reviewed By: p-sun Differential Revision: D31503119 fbshipit-source-id: 324e16fe0f6ad937ab2c38be9a536bdf14851172 --- .../ComponentViews/Modal/RCTModalHostViewComponentView.mm | 3 --- 1 file changed, 3 deletions(-) diff --git a/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm b/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm index 16ae9beeec2..5d2b1d347c3 100644 --- a/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm +++ b/React/Fabric/Mounting/ComponentViews/Modal/RCTModalHostViewComponentView.mm @@ -156,9 +156,6 @@ static ModalHostViewEventEmitter::OnOrientationChange onOrientationChangeStruct( auto eventEmitter = [self modalEventEmitter]; if (eventEmitter) { eventEmitter->onShow(ModalHostViewEventEmitter::OnShow{}); - - // A hack so that EventEmitter.cpp's eventTarget_ does not become null when modal is dismissed - eventEmitter->setEnabled(true); } }]; }