From c918f45046b7fef6465933291a92b879a9919445 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 21 Feb 2020 10:46:12 -0800 Subject: [PATCH] Enable support for TextInlineViews with dynamic sizes by default Summary: This diff enables support for TextInlineViews with dynamic sizes by default, removing old code and calls to MCs. changelog: [internal] Reviewed By: JoshuaGross, makovkastar Differential Revision: D20026795 fbshipit-source-id: 48adf356b418866d937be9b478d9186342a07de8 --- .../main/java/com/facebook/react/views/text/BUCK | 1 - .../views/text/ReactBaseTextShadowNode.java | 16 +++++----------- 2 files changed, 5 insertions(+), 12 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK index 9d05a349159..62458f6ae26 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/BUCK @@ -21,7 +21,6 @@ rn_android_library( react_native_dep("third-party/java/jsr-305:jsr-305"), react_native_target("java/com/facebook/react/bridge:bridge"), react_native_target("java/com/facebook/react/common:common"), - react_native_target("java/com/facebook/react/config:config"), react_native_target("java/com/facebook/react/module/annotations:annotations"), react_native_target("java/com/facebook/react/uimanager:uimanager"), react_native_target("java/com/facebook/react/uimanager/annotations:annotations"), diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java index b02fd06645d..e36cfa0c4ee 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactBaseTextShadowNode.java @@ -20,7 +20,6 @@ import com.facebook.infer.annotation.Assertions; import com.facebook.react.bridge.JSApplicationIllegalArgumentException; import com.facebook.react.bridge.ReadableArray; import com.facebook.react.bridge.ReadableMap; -import com.facebook.react.config.ReactFeatureFlags; import com.facebook.react.uimanager.IllegalViewOperationException; import com.facebook.react.uimanager.LayoutShadowNode; import com.facebook.react.uimanager.NativeViewHierarchyOptimizer; @@ -142,16 +141,11 @@ public abstract class ReactBaseTextShadowNode extends LayoutShadowNode { float width; float height; if (widthValue.unit != YogaUnit.POINT || heightValue.unit != YogaUnit.POINT) { - if (ReactFeatureFlags.supportInlineViewsWithDynamicSize) { - // If the measurement of the child isn't calculated, we calculate the layout for the - // view using Yoga - child.calculateLayout(); - width = child.getLayoutWidth(); - height = child.getLayoutHeight(); - } else { - throw new IllegalViewOperationException( - "Views nested within a must have a width and height"); - } + // If the measurement of the child isn't calculated, we calculate the layout for the + // view using Yoga + child.calculateLayout(); + width = child.getLayoutWidth(); + height = child.getLayoutHeight(); } else { width = widthValue.value; height = heightValue.value;