From c8f1506f13310ffafe370273805684e696d72d50 Mon Sep 17 00:00:00 2001 From: zhongwuzw Date: Tue, 28 Jan 2025 04:37:37 -0800 Subject: [PATCH] Clean up RCTBridgeDelegate to remove shouldBridgeUseCustomJSC method (#48948) Summary: `shouldBridgeUseCustomJSC` comes from https://github.com/zhongwuzw/react-native/commit/cb3e575deb8a2be972298b12761ed9ee8f0ae63d, seems it's not working anymore. So we can clean up it . ## Changelog: [IOS] [REMOVED] - Clean up RCTBridgeDelegate to remove shouldBridgeUseCustomJSC method Pull Request resolved: https://github.com/facebook/react-native/pull/48948 Test Plan: Everything should works. Reviewed By: christophpurrer Differential Revision: D68728588 Pulled By: javache fbshipit-source-id: 8a762b5f3d6272fa7be57e0b17cb655eba743b5d --- packages/react-native/React/Base/RCTBridgeDelegate.h | 9 --------- .../renderer/runtimescheduler/RuntimeScheduler_Modern.h | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/packages/react-native/React/Base/RCTBridgeDelegate.h b/packages/react-native/React/Base/RCTBridgeDelegate.h index 1bc3723ea9e..fc4d6313da9 100644 --- a/packages/react-native/React/Base/RCTBridgeDelegate.h +++ b/packages/react-native/React/Base/RCTBridgeDelegate.h @@ -40,15 +40,6 @@ NS_ASSUME_NONNULL_BEGIN */ - (NSArray> *)extraModulesForBridge:(RCTBridge *)bridge; -/** - * Configure whether the JSCExecutor created should use the system JSC API or - * alternative hooks provided. When returning YES from this method, you must have - * previously called facebook::react::setCustomJSCWrapper. - * - * @experimental - */ -- (BOOL)shouldBridgeUseCustomJSC:(RCTBridge *)bridge; - /** * The bridge will call this method when a module been called from JS * cannot be found among registered modules. diff --git a/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h b/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h index 0eaeb58bbd1..865980c0a3b 100644 --- a/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h +++ b/packages/react-native/ReactCommon/react/renderer/runtimescheduler/RuntimeScheduler_Modern.h @@ -42,7 +42,7 @@ class RuntimeScheduler_Modern final : public RuntimeSchedulerBase { * Alias for scheduleTask with immediate priority. * * To be removed when we finish testing this implementation. - * All callers should use scheduleTask with the right priority afte that. + * All callers should use scheduleTask with the right priority after that. */ void scheduleWork(RawCallback&& callback) noexcept override;