From c77c13ab7c8f16296e102190d4ab1df1badbcd3b Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 23 Feb 2024 02:42:20 -0800 Subject: [PATCH] Mark classes of package uimanager as @Nullsafe (#43156) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43156 All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: javache Differential Revision: D54027185 fbshipit-source-id: f3c337def2d42cf1f6fed2e2eb4938a84a51f8d4 --- .../java/com/facebook/react/uimanager/GuardedFrameCallback.java | 2 ++ .../facebook/react/uimanager/IllegalViewOperationException.java | 2 ++ 2 files changed, 4 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/GuardedFrameCallback.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/GuardedFrameCallback.java index 5f8115c0faa..9ed8000da17 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/GuardedFrameCallback.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/GuardedFrameCallback.java @@ -8,6 +8,7 @@ package com.facebook.react.uimanager; import android.view.Choreographer; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.react.bridge.JSExceptionHandler; import com.facebook.react.bridge.ReactContext; @@ -15,6 +16,7 @@ import com.facebook.react.bridge.ReactContext; * Abstract base for a Choreographer FrameCallback that should have any RuntimeExceptions it throws * handled by the {@link JSExceptionHandler} registered if the app is in dev mode. */ +@Nullsafe(Nullsafe.Mode.LOCAL) public abstract class GuardedFrameCallback implements Choreographer.FrameCallback { private final ReactContext mReactContext; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/IllegalViewOperationException.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/IllegalViewOperationException.java index 931f338e4bd..215293188ea 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/IllegalViewOperationException.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/IllegalViewOperationException.java @@ -9,9 +9,11 @@ package com.facebook.react.uimanager; import android.view.View; import androidx.annotation.Nullable; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.react.bridge.JSApplicationCausedNativeException; /** An exception caused by JS requesting the UI manager to perform an illegal view operation. */ +@Nullsafe(Nullsafe.Mode.LOCAL) public class IllegalViewOperationException extends JSApplicationCausedNativeException { @Nullable private View mView;