From c692a1185a6e7cc672d93c9ecdc27d6bc28e9ced Mon Sep 17 00:00:00 2001 From: Gijs Weterings Date: Wed, 9 Apr 2025 09:07:30 -0700 Subject: [PATCH] Apply nullsafe FIXMEs for xplat/js/react-native-github/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.java Summary: Added nullsafe FIXMEs for easier reviewing of next diff, where we fix them Changelog: [Internal] Reviewed By: alanleedev Differential Revision: D72384067 fbshipit-source-id: b9cc92e41f29cd5af4d277ee8ec0cb3c432bdeec --- .../java/com/facebook/react/bridge/DynamicFromObject.java | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.java index 226749c5bbd..4fc60df1458 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/DynamicFromObject.java @@ -31,32 +31,38 @@ public class DynamicFromObject implements Dynamic { @Override public boolean asBoolean() { + // NULLSAFE_FIXME[Nullable Dereference] return (boolean) mObject; } @Override public double asDouble() { + // NULLSAFE_FIXME[Nullable Dereference] return (double) mObject; } @Override public int asInt() { // Numbers from JS are always Doubles + // NULLSAFE_FIXME[Nullable Dereference] return ((Double) mObject).intValue(); } @Override public String asString() { + // NULLSAFE_FIXME[Return Not Nullable] return (String) mObject; } @Override public ReadableArray asArray() { + // NULLSAFE_FIXME[Return Not Nullable] return (ReadableArray) mObject; } @Override public ReadableMap asMap() { + // NULLSAFE_FIXME[Return Not Nullable] return (ReadableMap) mObject; }