From c68c55469fe9e2e03cdd6d9201172bd2b49c07e8 Mon Sep 17 00:00:00 2001 From: Neil Dhar Date: Fri, 23 Apr 2021 17:45:33 -0700 Subject: [PATCH] Initialise LineMeasurement::xHeight in constructor Summary: Fix a bug in the constructor of `LineMeasurement` where it did not initialise `xHeight` correctly. Changelog: [Internal] Reviewed By: JoshuaGross Differential Revision: D27972942 fbshipit-source-id: a56d55fdfe286bd11a6a81a3d024504f070bdb19 --- .../react/renderer/textlayoutmanager/TextMeasureCache.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.cpp b/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.cpp index db9910fecb5..76bbc45c963 100644 --- a/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.cpp +++ b/ReactCommon/react/renderer/textlayoutmanager/TextMeasureCache.cpp @@ -34,7 +34,8 @@ LineMeasurement::LineMeasurement( frame(frame), descender(descender), capHeight(capHeight), - ascender(ascender) {} + ascender(ascender), + xHeight(xHeight) {} LineMeasurement::LineMeasurement(folly::dynamic const &data) : text(data.getDefault("text", "").getString()),