Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Convert modules to use @ReactModule instead of getName()

Browse Source 
Reviewed By: astreet

Differential Revision: D3334273

fbshipit-source-id: a33bf72c5c184844885ef3ef610a05d9c102c8ea
This commit is contained in:
Aaron Chiu
2016-08-11 15:58:43 -07:00
committed by Facebook Github Bot 2
parent 9965642ebc
commit c64213653e
40 changed files with 103 additions and 255 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/modules/debug/AnimationsDebugModule.java
+2 -5
View File
@@ -22,12 +22,14 @@ import com.facebook.react.bridge.JSApplicationCausedNativeException;
import com.facebook.react.bridge.ReactApplicationContext;
import com.facebook.react.bridge.ReactContextBaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.annotations.ReactModule;
import com.facebook.react.common.ReactConstants;
/**
* Module that records debug information during transitions (animated navigation events such as
* going from one screen to another).
*/
@ReactModule(name = "AnimationsDebugModule")
public class AnimationsDebugModule extends ReactContextBaseJavaModule {
private @Nullable FpsDebugFrameCallback mFrameCallback;
@@ -40,11 +42,6 @@ public class AnimationsDebugModule extends ReactContextBaseJavaModule {
mCatalystSettings = catalystSettings;
}
@Override
public String getName() {
return "AnimationsDebugModule";
}
@ReactMethod
public void startRecordingFps() {
if (mCatalystSettings == null ||
ReactAndroid/src/main/java/com/facebook/react/modules/debug/SourceCodeModule.java
+2 -9
View File
@@ -14,15 +14,13 @@ import javax.annotation.Nullable;
import java.util.HashMap;
import java.util.Map;
import com.facebook.react.bridge.Promise;
import com.facebook.react.bridge.BaseJavaModule;
import com.facebook.react.bridge.ReactMethod;
import com.facebook.react.bridge.WritableMap;
import com.facebook.react.bridge.WritableNativeMap;
import com.facebook.react.bridge.annotations.ReactModule;
/**
* Module that exposes the URL to the source code map (used for exception stack trace parsing) to JS
*/
@ReactModule(name = "RCTSourceCode")
public class SourceCodeModule extends BaseJavaModule {
private final String mSourceUrl;
@@ -31,11 +29,6 @@ public class SourceCodeModule extends BaseJavaModule {
mSourceUrl = sourceUrl;
}
@Override
public String getName() {
return "RCTSourceCode";
}
@Override
public @Nullable Map<String, Object> getConstants() {
HashMap<String, Object> constants = new HashMap<String, Object>();