From c63882238bc6b052109b1250e8bc5ef7de92bc53 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Mon, 24 Oct 2022 10:44:39 -0700 Subject: [PATCH] Back out "add oncall annotation for BUCK files in xplat based on supermodule information - /home/s2shi/tmp/xplat_buck_oncall/xplat_buck_2nd_batch00" (#35065) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/35065 Original commit changeset: ac76ea701e3d Original Phabricator Diff: D40611860 (https://github.com/facebook/react-native/commit/860b4d914407ef11d0d5de80e5add275f83de3fd) Open source is using BUCK 1 which does not seem to have the `oncall` directive. Backing it out because it is breaking the external CI. ## Changelog [internal] Reviewed By: cortinico Differential Revision: D40637084 fbshipit-source-id: 2be7296f859412210afe981adf500ab6540f7ee8 --- IntegrationTests/BUCK | 2 -- ReactAndroid/src/androidTest/js/BUCK | 2 -- ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK | 2 -- ReactAndroid/src/main/java/com/facebook/react/views/modal/BUCK | 2 -- .../src/main/java/com/facebook/react/views/progressbar/BUCK | 2 -- ReactAndroid/src/main/java/com/facebook/react/views/slider/BUCK | 2 -- .../src/main/java/com/facebook/react/views/swiperefresh/BUCK | 2 -- .../src/main/java/com/facebook/react/views/switchview/BUCK | 2 -- ReactAndroid/src/main/jni/react/fabric/BUCK | 2 -- ReactCommon/react/renderer/components/inputaccessory/BUCK | 2 -- .../react/renderer/components/legacyviewmanagerinterop/BUCK | 2 -- ReactCommon/react/renderer/components/modal/BUCK | 2 -- ReactCommon/react/renderer/components/progressbar/BUCK | 2 -- ReactCommon/react/renderer/components/safeareaview/BUCK | 2 -- ReactCommon/react/renderer/components/slider/BUCK | 2 -- ReactCommon/react/renderer/components/switch/BUCK | 2 -- 16 files changed, 32 deletions(-) diff --git a/IntegrationTests/BUCK b/IntegrationTests/BUCK index 6ae65ac68a2..0ac92a5c69e 100644 --- a/IntegrationTests/BUCK +++ b/IntegrationTests/BUCK @@ -4,8 +4,6 @@ load("@fbsource//tools/build_defs/oss:metro_defs.bzl", "rn_library") # This file was generated by running # js1 build buckfiles -oncall("react_native") - rn_library( name = "IntegrationTests", srcs = js_library_glob( diff --git a/ReactAndroid/src/androidTest/js/BUCK b/ReactAndroid/src/androidTest/js/BUCK index d5a0d0c4f01..c7b68b54681 100644 --- a/ReactAndroid/src/androidTest/js/BUCK +++ b/ReactAndroid/src/androidTest/js/BUCK @@ -4,8 +4,6 @@ load("//tools/build_defs/oss:metro_defs.bzl", "rn_library") # This file was generated by running # js1 build buckfiles -oncall("react_native") - rn_library( name = "js", srcs = js_library_glob( diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK index 7103f892da3..9677362369c 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/drawer/BUCK @@ -1,7 +1,5 @@ load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library") -oncall("react_native") - rn_android_library( name = "drawer", srcs = glob(["**/*.java"]), diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/modal/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/modal/BUCK index 3ab01fb07b0..4418ccfcfe5 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/modal/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/modal/BUCK @@ -1,7 +1,5 @@ load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library") -oncall("react_native") - rn_android_library( name = "modal", srcs = glob(["*.java"]), diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/BUCK index 94e61b2b3d7..52d4b639706 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/progressbar/BUCK @@ -1,7 +1,5 @@ load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library") -oncall("react_native") - rn_android_library( name = "progressbar", srcs = glob(["*.java"]), diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/slider/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/slider/BUCK index 68fcd2b701a..e402f20b8b6 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/slider/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/slider/BUCK @@ -1,7 +1,5 @@ load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library") -oncall("react_native") - rn_android_library( name = "slider", srcs = glob(["*.java"]), diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/swiperefresh/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/swiperefresh/BUCK index 8892b1249fe..a1fe56f942e 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/swiperefresh/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/swiperefresh/BUCK @@ -1,7 +1,5 @@ load("//tools/build_defs/oss:rn_defs.bzl", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library") -oncall("react_native") - rn_android_library( name = "swiperefresh", srcs = glob(["*.java"]), diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/switchview/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/switchview/BUCK index fa4b172a597..ad8db8e74ea 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/switchview/BUCK +++ b/ReactAndroid/src/main/java/com/facebook/react/views/switchview/BUCK @@ -1,7 +1,5 @@ load("//tools/build_defs/oss:rn_defs.bzl", "YOGA_TARGET", "react_native_dep", "react_native_root_target", "react_native_target", "rn_android_library") -oncall("react_native") - rn_android_library( name = "switchview", srcs = glob(["*.java"]), diff --git a/ReactAndroid/src/main/jni/react/fabric/BUCK b/ReactAndroid/src/main/jni/react/fabric/BUCK index 141ff37cef9..b8e6516cb04 100644 --- a/ReactAndroid/src/main/jni/react/fabric/BUCK +++ b/ReactAndroid/src/main/jni/react/fabric/BUCK @@ -1,7 +1,5 @@ load("//tools/build_defs/oss:rn_defs.bzl", "ANDROID", "FBJNI_TARGET", "react_native_target", "react_native_xplat_target", "rn_xplat_cxx_library", "subdir_glob") -oncall("react_native") - rn_xplat_cxx_library( name = "jni", srcs = glob(["*.cpp"]), diff --git a/ReactCommon/react/renderer/components/inputaccessory/BUCK b/ReactCommon/react/renderer/components/inputaccessory/BUCK index e009e4bacf6..33df142a8c6 100644 --- a/ReactCommon/react/renderer/components/inputaccessory/BUCK +++ b/ReactCommon/react/renderer/components/inputaccessory/BUCK @@ -9,8 +9,6 @@ load( "subdir_glob", ) -oncall("react_native") - APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( diff --git a/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK b/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK index d6177292f60..5e0a1f46189 100644 --- a/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK +++ b/ReactCommon/react/renderer/components/legacyviewmanagerinterop/BUCK @@ -9,8 +9,6 @@ load( "subdir_glob", ) -oncall("react_native") - APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( diff --git a/ReactCommon/react/renderer/components/modal/BUCK b/ReactCommon/react/renderer/components/modal/BUCK index c482946bfb4..c95a9146013 100644 --- a/ReactCommon/react/renderer/components/modal/BUCK +++ b/ReactCommon/react/renderer/components/modal/BUCK @@ -12,8 +12,6 @@ load( "subdir_glob", ) -oncall("react_native") - APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( diff --git a/ReactCommon/react/renderer/components/progressbar/BUCK b/ReactCommon/react/renderer/components/progressbar/BUCK index 1a27e387cb1..1cbc166b322 100644 --- a/ReactCommon/react/renderer/components/progressbar/BUCK +++ b/ReactCommon/react/renderer/components/progressbar/BUCK @@ -14,8 +14,6 @@ load( "subdir_glob", ) -oncall("react_native") - APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( diff --git a/ReactCommon/react/renderer/components/safeareaview/BUCK b/ReactCommon/react/renderer/components/safeareaview/BUCK index 53162f8fd7d..544c8c8c9e5 100644 --- a/ReactCommon/react/renderer/components/safeareaview/BUCK +++ b/ReactCommon/react/renderer/components/safeareaview/BUCK @@ -9,8 +9,6 @@ load( "subdir_glob", ) -oncall("react_native") - APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( diff --git a/ReactCommon/react/renderer/components/slider/BUCK b/ReactCommon/react/renderer/components/slider/BUCK index 1ef1f24b16f..7cc3f2f6849 100644 --- a/ReactCommon/react/renderer/components/slider/BUCK +++ b/ReactCommon/react/renderer/components/slider/BUCK @@ -14,8 +14,6 @@ load( "subdir_glob", ) -oncall("react_native") - APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library( diff --git a/ReactCommon/react/renderer/components/switch/BUCK b/ReactCommon/react/renderer/components/switch/BUCK index d9205017cf2..881670fdbda 100644 --- a/ReactCommon/react/renderer/components/switch/BUCK +++ b/ReactCommon/react/renderer/components/switch/BUCK @@ -13,8 +13,6 @@ load( "subdir_glob", ) -oncall("react_native") - APPLE_COMPILER_FLAGS = get_apple_compiler_flags() rn_xplat_cxx_library(